From owner-svn-src-all@freebsd.org Wed Jan 10 17:14:26 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87B38E68C2E for ; Wed, 10 Jan 2018 17:14:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 420817F41A for ; Wed, 10 Jan 2018 17:14:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id e20so173057iof.12 for ; Wed, 10 Jan 2018 09:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PgKNrTscNkp8UxoP4w7DSfx+ZuSqkCCN7q6zUWgka0E=; b=lu8CDv05+o1IJePZlDOGlRyfSBHpaYh/0gXd6aLjIMu1Eit9dia9NQ4EMd2YaIC2wA /s5G0RE5/A7fL0SXnZVXPPjk9RB2M/LZd4aJLq3A5G3I+it+2+AFZ2L1+dZpOVSaESTw 0SXslHSmqeMjaz8PoNKGgvuOS76XggF7MTr8meMwnKGiUZwRB5Ix5+Cg0IPXY98ufN+v O9mygwBnlnKBErBLBEmfhON/aDFetuEGTvJsinJU04WL4eMlQP7Y6yvz1GNLfiHIS06F dc/KmVCI7hlFKK1GYT+4tj2uBWl8s+9mdlvgEDZNLiKTQtduhgJn3YYY6x4VeqDEDt14 JYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PgKNrTscNkp8UxoP4w7DSfx+ZuSqkCCN7q6zUWgka0E=; b=R+Ede7Bt9t+c6aKC1iKbD/rtQmXw173oesmXRC8p0+sTasveMtexnbeDA/zzdE9dWg 9yyntfF4L7wcPq1p2otf1ubx6hAop5m0NtEVUXLLJ8I7cqvD5Je8+D7tbuK88x7DV5h5 lCSc9Wa0DFqLZ1JB4H778Uz5FaK1VTC6OdHzza35pJQGUEDMwO60DVXibCjW/JssQtY+ jC75f7LoFx9klch+T8lS78g9+bPRfpoAMeFcmfH7pfX7a+Ajd8W14ArWdZcSixO4sqFD TXqu7BmSLdBBX/Uzc0xnvBS7FbwgUbWvHDkEB+677/QoIhq6341kgqrnNzdOtgB72tll LesQ== X-Gm-Message-State: AKGB3mL/vvE1+LFwoX+5GqbXbiXmhB/iGvKGoXmyo6uJE+FC1oTA5kJp ZDclho29/lnK4Hhwa0egYCqHXd9LhN+uvJu+GxXtQA== X-Google-Smtp-Source: ACJfBou2DTy6RO/inYTEroPyYqBgax5B7sms7y1NolrwH3kuhaLhgV8uVJt7KW4fZp2BhPBdj2fTfmQ9/SncCzcXOrs= X-Received: by 10.107.180.151 with SMTP id d145mr17227961iof.136.1515604465415; Wed, 10 Jan 2018 09:14:25 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.160.217 with HTTP; Wed, 10 Jan 2018 09:14:24 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201801101459.w0AExJWM055025@repo.freebsd.org> <201801101631.w0AGVAEV032087@pdx.rh.CN85.dnsmgr.net> <20180110165821.GA69465@FreeBSD.org> From: Warner Losh Date: Wed, 10 Jan 2018 10:14:24 -0700 X-Google-Sender-Auth: GEuAve0McutLQipCKoo8O41IStY Message-ID: Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa To: Alexey Dokuchaev Cc: "Rodney W. Grimes" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:14:26 -0000 On Wed, Jan 10, 2018 at 10:01 AM, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev > wrote: > >> On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: >> > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: >> > > > New Revision: 327767 >> > > > URL: https://svnweb.freebsd.org/changeset/base/327767 >> > > > >> > > > Log: >> > > > Retire pmtimer driver. Move time fixing into apm driver. Move >> > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't >> possibly >> > > > work. Call tc_settime() with our estimate of the delta we've been >> > > > alseep (the one we print) to adjust the time. Not sure what to do >> > > > about callouts, so keep the small #ifdef in place there. >> > > > >> > > > Differential Revision: https://reviews.freebsd.org/D13823 >> > > >> > > RELNOTES: ? >> > > Reason I ask is this effects custom kernel config file(s) >> > >> > Don't know. We don't normally document every kernel config file changes >> > that's required. >> >> Well, `pmtimer' is a bit special. It is required in the kernel config in >> order to preserve time counting during suspend (not sure about amd64, but >> at least on i386, "device pmtimer" is required to be in kernel config for >> timekeeping while sleeping). >> > > It's only required for APM. ACPI it's a nop. > This part is true. Well, it was only required for APM. Not it's not required at all since, like ACPI, APM sets the time internally. > And it didn't (until I believe that I fixed it) even adjust the time for > APM. On APM it just prints how long the sleep was. > That last bit of what I wrote was wrong. The FIXME lead me to believe time wasn't being set, but the inittodr(0) sets time. Warner