From nobody Mon Feb 9 06:57:20 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8b9D3wFMz6Qh8p for ; Mon, 09 Feb 2026 06:57:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8b9D2ynkz46Q3 for ; Mon, 09 Feb 2026 06:57:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770620240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCAPwFAXSjycITpAhh4tBzMUzc3OqrUcI6rDZ1XOTH8=; b=kDsMuujiCUHZ7+tH0M41g64Ft4hAFFfBZeo9hMeyMJUCQTh/lXt5vsrCH702n9WAQv4raF pyTXyCbKrTD6uefGOfas/+XPElOcz9iHXgeljBKijh0/qzFeNANguxVer8l2ngQICQfGtI SbwzI9xnfjushbzGjVV9VxYQvSncCar2B2jc8Yp0XVkD+SGzQIJWmpiEzq7qLUQAAp1I4D R5hM4qzlDWn6WImI7z3EpampXnG0jAmGs5VLJjXOXAUOGy21xs//HqwHByBOc/E3jr92qt HX++lzXtDJBUYjyFmPd45Zp04qeniJeOlSaJhHgEGHAubYN+J3DK5ABPAH7wIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770620240; a=rsa-sha256; cv=none; b=NXVkXAwBsTYNTF/C6SPsGgV2E8rpXDBT1mFldt2CkeN3D5a9Ev3/huErgrEAK9EOr6CBNe Am/G+HYkbKk2tzMCvkjWeDGwVksD7KWxymvjn2j2aodYMMSV+ZRHBfkbzeXW4p3lIj9c+G qJLXzLIvSTJIwPFpWWO5OKFtcMiOCCh2q79x8XVr8+qKG5/MMkeckvNig5IVBdj2Pzi6Qd 3uXgip5PSyJEs/hnwNgnuVZ1XJpi3cXG1VGA3lje9XrKIY9Jd05T2umhIY6Vfw7eXyEc0J 0bbikgGLjjOQY44xWB7wQr6T4xwGrs/ux6JsFUM5P9B1jZcQhyt/d5yKZlIj6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770620240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCAPwFAXSjycITpAhh4tBzMUzc3OqrUcI6rDZ1XOTH8=; b=yP9DK52a4TTT+17EAm7NOjh6iilVqMVf2bZlQ1R+Q8oU+96XCmVED6JU03eIaubD4Yx/AQ +LvBDP3r7UwVqXl48jwOR9W39+hCIXLRz20QUmSngiU6UNAdeTNEWK4npZmiTmo6ceuLKF FPisw+f29G01MbN+9YCjvgf19gcHs8APg9JJl7KmB6+PeE/3PqmjExewlHgyQ8zcbAQuPY L7ryLsXq5EE1O9z8UAHiYf3/BiARLEb+gb4FgMWR93KmzKOASGfTIDFC12ns24LQVa5r0x 0QwB95vXhNeedLr5bbMxM9V8nRNIjFjonT1Z1Jot16Y28NPalpVLgezDXIOOvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f8b9D2FW1z6rl for ; Mon, 09 Feb 2026 06:57:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39e6d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Feb 2026 06:57:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Yogesh Bhosale From: Kevin Bowling Subject: git: 2f91ff89c56e - stable/14 - ice(4): Handle allmulti flag in ice_if_promisc_set function List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2f91ff89c56eb18c0979ba6050f66bfd50c9aef5 Auto-Submitted: auto-generated Date: Mon, 09 Feb 2026 06:57:20 +0000 Message-Id: <69898550.39e6d.98732c5@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=2f91ff89c56eb18c0979ba6050f66bfd50c9aef5 commit 2f91ff89c56eb18c0979ba6050f66bfd50c9aef5 Author: Yogesh Bhosale AuthorDate: 2026-02-01 17:27:36 +0000 Commit: Kevin Bowling CommitDate: 2026-02-09 06:57:05 +0000 ice(4): Handle allmulti flag in ice_if_promisc_set function In the ice_if_promisc_set function, the driver currently disables the IFF_ALLMULTI flag, thereby preventing the activation of multicast mode. To address this issue, implement appropriate handling to ensure the flag is managed correctly. Signed-off-by: Yogesh Bhosale Tested by: Gowthamkumar K S Differential Revision: https://reviews.freebsd.org/D54186 (cherry picked from commit 98bdf63f6e94be42a1787de73608de15bcb3419a) --- sys/dev/ice/if_ice_iflib.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/sys/dev/ice/if_ice_iflib.c b/sys/dev/ice/if_ice_iflib.c index e60ee0f1c5c3..a844df9d5a4a 100644 --- a/sys/dev/ice/if_ice_iflib.c +++ b/sys/dev/ice/if_ice_iflib.c @@ -1866,15 +1866,13 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) ice_set_default_promisc_mask(promisc_mask); - if (multi_enable) - return (EOPNOTSUPP); - if (promisc_enable) { status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, promisc_mask, 0); if (status && status != ICE_ERR_ALREADY_EXISTS) { device_printf(dev, - "Failed to enable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to enable promiscuous mode for " + "PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); @@ -1884,11 +1882,28 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) promisc_mask, 0); if (status) { device_printf(dev, - "Failed to disable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to disable promiscuous mode for" + " PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); } + + if (multi_enable) { + ice_clear_bit(ICE_PROMISC_UCAST_TX, promisc_mask); + ice_clear_bit(ICE_PROMISC_UCAST_RX, promisc_mask); + status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, + promisc_mask, 0); + if (status && status != ICE_ERR_ALREADY_EXISTS) { + device_printf(dev, + "Failed to enable allmulti mode " + "for PF VSI, err %s aq_err %s\n", + ice_status_str(status), + ice_aq_str( + hw->adminq.sq_last_status)); + return (EIO); + } + } } return (0);