From owner-freebsd-current@freebsd.org Sun Sep 27 02:55:55 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 284323E9D7D; Sun, 27 Sep 2020 02:55:55 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BzVdk16Rfz4Pv2; Sun, 27 Sep 2020 02:55:53 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f178.google.com with SMTP id t76so7449027oif.7; Sat, 26 Sep 2020 19:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MSNJCzZoy1fgm/a8nqe243dFVDzmnq/D3cnvhiAAhcQ=; b=VTqrTZ6mSFwtxdHuHhYIs6AH+QdFmPnqoLSAgUNqHgqcbAERP5OcDxDTMPiGFWv1+U Hn5xffL3eqlIEPaHckXBTrXxuJEmnnub8Reo5UIuNi9gzLj8to7bBBQzS2bQKpXTAKW2 1xDWWkgZyDxbYt4UTbrniFaLZ2w8k7gsTqc0rI+Iv72691azNeS/B5+CwO9lCJ28vdv4 0nZF9Rlv5WbGvTV3EUZvdZN1w0iHxQJvuKnnHPkrW/cWWadU/7X3CF8nQh31+3Da3kSt 7VLPypcnJhwVUlHbTLaaHyp0v/8Z4N6OKQ45huw7pkeN6T5BtgtLdOzrRHedbPtoh2Aa zckQ== X-Gm-Message-State: AOAM533LWv/JCzR9icGF/2MVeZgUElk3oO5Ds5typCIprkrISbpcuEY5 aLBmqXXMdAkCctIt6WjzBOQGV7LABh7TTsCO2WE= X-Google-Smtp-Source: ABdhPJwh6GoKfjO40kUJVFVk09DjoR9YkDVAsrtRLaxcz/Z1dIqIL5M2dEqy94gZ1/26/+vdRUBtMqJ2lBmPI8qImqI= X-Received: by 2002:a05:6808:555:: with SMTP id i21mr2491746oig.55.1601175352478; Sat, 26 Sep 2020 19:55:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Sat, 26 Sep 2020 20:55:41 -0600 Message-ID: Subject: Re: RFC: should copy_file_range(2) remain Linux compatible or support special files? To: Rick Macklem Cc: "Wall, Stephen" , FreeBSD Hackers , "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 4BzVdk16Rfz4Pv2 X-Spamd-Bar: - X-Spamd-Result: default: False [-1.69 / 15.00]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.01)[-1.013]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.70)[-0.698]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.178:from]; NEURAL_HAM_MEDIUM(-0.98)[-0.978]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.178:from]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-current] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2020 02:55:55 -0000 On Sat, Sep 26, 2020 at 8:52 PM Rick Macklem wrote: > Wall, Stephen wrote: > > Could the as yet unused options param have a bit assigned to trigger the > new > > behavior? Inform the linux community of the addition and let them > decide if they > > would like to adopt it as well. > I'll assume you are referring to the "flags" argument when you say "param" > above. > > You could. However, since the Linux man page says it will return EINVAL if > the "flags" argument is non-zero, you've still introduced an > incompatibility > w.r.t. the Linux behaviour. > It does make it clear that copy_file_range(2) will have the non-Linux > behaviour > when the flag is specified, which I think is a good idea. > I think it's just syntactic salt. Why require extra work for so little purpose? My opinion is that if we can make it work for character devices, we should.