From owner-freebsd-mobile Wed Jul 14 17:18:47 1999 Delivered-To: freebsd-mobile@freebsd.org Received: from ns.mt.sri.com (ns.mt.sri.com [206.127.79.91]) by hub.freebsd.org (Postfix) with ESMTP id DDD2B14E90 for ; Wed, 14 Jul 1999 17:18:43 -0700 (PDT) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id SAA12636; Wed, 14 Jul 1999 18:18:00 -0600 (MDT) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id SAA00008; Wed, 14 Jul 1999 18:17:59 -0600 Date: Wed, 14 Jul 1999 18:17:59 -0600 Message-Id: <199907150017.SAA00008@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Warner Losh Cc: mobile@FreeBSD.ORG Subject: Re: pccardd patches for review In-Reply-To: <199907140636.AAA53085@harmony.village.org> References: <199907140636.AAA53085@harmony.village.org> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > Comments? You asked. The addition of block paren's were they are un-necessary violates style(9), which is the format of the code. (I know because I was forced to re-indent the whole base as it had so many different style formats that it was difficult to follow.) Should logerr be used instead of logmsg when an error occurs? Hosokawa-san should be asked about the delays, as many of them came from PAO vi him. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message