From owner-cvs-all Fri Jun 12 11:40:06 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA10740 for cvs-all-outgoing; Fri, 12 Jun 1998 11:40:06 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from austin.polstra.com (austin.polstra.com [206.213.73.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA10568; Fri, 12 Jun 1998 11:39:15 -0700 (PDT) (envelope-from jdp@austin.polstra.com) Received: from austin.polstra.com (jdp@localhost) by austin.polstra.com (8.8.8/8.8.8) with ESMTP id LAA12877; Fri, 12 Jun 1998 11:39:12 -0700 (PDT) (envelope-from jdp) Message-Id: <199806121839.LAA12877@austin.polstra.com> To: julian@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_ethersubr.c if_fddisubr.c if_loop.c if_var.h src/sys/netatalk ddp_output.c src/sys/netinet if_ether.c ip_input.c ip_output.c In-Reply-To: <199806120348.UAA18762@freefall.freebsd.org> References: <199806120348.UAA18762@freefall.freebsd.org> Organization: Polstra & Co., Seattle, WA Cc: committers@FreeBSD.ORG Date: Fri, 12 Jun 1998 11:39:12 -0700 From: John Polstra Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In article <199806120348.UAA18762@freefall.freebsd.org>, Julian Elischer wrote: > julian 1998/06/11 20:48:20 PDT > > Modified files: > sys/net if_ethersubr.c if_fddisubr.c if_loop.c > if_var.h > sys/netatalk ddp_output.c > sys/netinet if_ether.c ip_input.c ip_output.c > Log: > Go through the loopback code with a broom.. > Remove lots'o'hacks. > looutput is now static. > > Other callers who want to use loopback to allow shortcutting > should call the special entrypoint for this, if_simloop(), which is > specifically designed for this purpose. Using looutput for this purpose > was problematic, particularly with bpf and trying to keep track > of whether one should be using the charateristics of the loopback interface > or the interface (e.g. if_ethersubr.c) that was requesting the loopback. > There was a whole class of errors due to this mis-use each of which had > hacks to cover them up. > > Consists largly of hack removal :-) > > Revision Changes Path > 1.49 +35 -97 src/sys/net/if_ethersubr.c > 1.31 +30 -60 src/sys/net/if_fddisubr.c > 1.33 +62 -27 src/sys/net/if_loop.c > 1.9 +3 -3 src/sys/net/if_var.h > 1.10 +9 -0 src/sys/netatalk/ddp_output.c > 1.47 +10 -10 src/sys/netinet/if_ether.c > 1.90 +2 -7 src/sys/netinet/ip_input.c > 1.72 +4 -4 src/sys/netinet/ip_output.c On a separate note, could you please go in and remove the uses of the __FUNCTION__ macro? There's no real need to use it, and it adds a gratuitous dependency on GCC. John -- John Polstra jdp@polstra.com John D. Polstra & Co., Inc. Seattle, Washington USA "Self-knowledge is always bad news." -- John Barth To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message