From owner-svn-ports-all@FreeBSD.ORG  Mon Oct  6 07:00:54 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1660A394;
 Mon,  6 Oct 2014 07:00:54 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DD00695C;
 Mon,  6 Oct 2014 07:00:53 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id ED1C4438BD;
 Mon,  6 Oct 2014 02:00:34 -0500 (CDT)
Message-ID: <54323E01.4080109@marino.st>
Date: Mon, 06 Oct 2014 09:00:17 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Andrej Zverev <az@freebsd.org>, John Marino <marino@freebsd.org>
Subject: Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl
References: <201410052140.s95LeUa9030114@svn.freebsd.org>	<CAD5bB+g5oUuWUXLpJia7vssd0SjTwn+0geRZApPULtQn+_gDxQ@mail.gmail.com>	<54323187.7040603@marino.st>
 <CAD5bB+gVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ@mail.gmail.com>
In-Reply-To: <CAD5bB+gVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Bartek Rutkowski <robak@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2014 07:00:54 -0000

On 10/6/2014 08:34, Andrej Zverev wrote:
> Hello John,
> 
> I don't see why shebangfix can't handle space.
> _SHEBANG_REINPLACE_ARGS+=       -e
> "1s|^\#![[:space:]]*${${lang}_OLD_CMD}|\#!${${lang}_CMD}|"

Actually I only took the other person's word that it didn't work when he
responded to "why didn't you use shebangfix?".  I don't know if he was
mistaken or maybe shebangfix has been improved in the meantime.

> Even if it can't you can make some handwork to obey framework instead of
> making one more way of doing this :-)

i essentially agree with you.

> But anyway, what about LOCALBASE and shebangfix? I think they can be
> fixed. If you prefer I can provide patch. Please don't get my email as
> something bad, If something can be done better so why not.

I didn't take it as bad.
I didn't respond to LOCALBASE because I thought it was valid and I left
that to robak to answer.  Probably both LOCALBASE and SHEBANGFIX should
be tweaked IMO.

John