From owner-freebsd-virtualization@FreeBSD.ORG Sat May 16 12:25:57 2015 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 92D44490 for ; Sat, 16 May 2015 12:25:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 692E7100E for ; Sat, 16 May 2015 12:25:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t4GCPvp3067956 for ; Sat, 16 May 2015 12:25:57 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4GCPvNY067955; Sat, 16 May 2015 12:25:57 GMT (envelope-from daemon-user) Date: Sat, 16 May 2015 12:25:57 +0000 To: freebsd-virtualization@freebsd.org From: "nvass-gmx.com (Nikos Vassiliadis)" Subject: [Differential] [Commented On] D1944: PF and VIMAGE fixes Message-ID: <2d869212c86d7fa18f94762d5b91e592@localhost.localdomain> X-Priority: 3 Thread-Topic: D1944: PF and VIMAGE fixes X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFVXN1U= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 May 2015 12:25:57 -0000 nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47231, @rodrigc wrote: > I tested this patch. > > # kldload pf > # kldunload pf > kldunload: can't unload file: Device busy > > > The fact that the pf module cannot be unloaded was one of the > reasons that @glebius used to back out the entire changeset last time > I committed your pf changes. Can you fix this? This is intended behaviour, regadless of VIMAGE. You need to use kldunload -f to unload it. > I also saw this in dmesg: > > CURVNET_SET() recursion in pfi_vnet_initialize() line 130, prev in vnet_register_sysinit() > 0xfffff800056e4100 -> 0xfffff800056e4100 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe046389a550 > pfi_vnet_initialize() at pfi_vnet_initialize+0x21b/frame 0xfffffe046389a590 > pf_vnet_init() at pf_vnet_init+0x35/frame 0xfffffe046389a5c0 > vnet_register_sysinit() at vnet_register_sysinit+0x13c/frame 0xfffffe046389a600 > linker_load_module() at linker_load_module+0xc87/frame 0xfffffe046389a920 > kern_kldload() at kern_kldload+0x10e/frame 0xfffffe046389a970 > sys_kldload() at sys_kldload+0x5b/frame 0xfffffe046389a9a0 > amd64_syscall() at amd64_syscall+0x27f/frame 0xfffffe046389aab0 > Xfast_syscall() at Xfast_syscall+0xfb/frame 0xfffffe046389aab0 > This should be ok. It is just a warning that we are setting curvnet although it is already set. Maybe it can be avoided. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, glebius, rodrigc, kristof, gnn Cc: julian, robak, freebsd-virtualization, freebsd-pf, freebsd-net