From owner-cvs-src@FreeBSD.ORG Thu Aug 26 13:32:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 643FB16A4D1 for ; Thu, 26 Aug 2004 13:32:25 +0000 (GMT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94F7743D1D for ; Thu, 26 Aug 2004 13:32:24 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i7QDT7cr045580 for cvs-src@FreeBSD.org.checked; (8.12.8/vak/2.1) Thu, 26 Aug 2004 17:29:07 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hi.cronyx.ru [144.206.181.94]) by hanoi.cronyx.ru with ESMTP id i7QDRqbQ045516; (8.12.8/vak/2.1) Thu, 26 Aug 2004 17:27:53 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <412DE5B1.9090101@cronyx.ru> Date: Thu, 26 Aug 2004 17:29:21 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200408261242.i7QCgl7m012027@repoman.freebsd.org> <58622.1093524972@critter.freebsd.dk> <20040826131030.GO30151@darkness.comp.waw.pl> In-Reply-To: <20040826131030.GO30151@darkness.comp.waw.pl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label src/sys/geom/stripe g_stripe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 13:32:28 -0000 Pawel Jakub Dawidek wrote: >On Thu, Aug 26, 2004 at 02:56:12PM +0200, Poul-Henning Kamp wrote: >+> In message <200408261242.i7QCgl7m012027@repoman.freebsd.org>, Pawel Jakub Dawid >+> ek writes: >+> >+> > Log: >+> > Skip providers with not defined sector size. >+> >+> This is wrong. A provider with a non-zero access count should always >+> have a sector size. The sectorsize can not be trusted if the access >+> counts are zero. > >Yes, I know that it should be done this way, but I'm not going to fix >atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else. >Those classes set error to 0 even when provider has not sectorsize >and mediasize defined. > > Does your code print any warning message in that case? That could force authors of 'buggy' code to fix it. rik