From nobody Sat Jun 4 18:38:44 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5BED91BE9A62 for ; Sat, 4 Jun 2022 18:38:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LFpS00b81z3w65 for ; Sat, 4 Jun 2022 18:38:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vs1-xe2a.google.com with SMTP id 68so10228017vse.11 for ; Sat, 04 Jun 2022 11:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+RAofBvF7PXUkOEwV8bOjl0vZgfzh3tQd0a74lClFHk=; b=toddpk7nbsBVUJ/SrOttsJf15Hy+zrn7p2ddj3gS+lMPMMQNoRwvJSOyZF89JDAkk4 Sjek8SYmIgkYppOlN+5LQ1CHczixDt/bQjR/gn5a3TSQTXVTxf6DlTPau8iXLyZlTdlR leYBnli+LEL0P6vpwz4MH9o2lCfqBJUUaEeRSASf28I3W06D5QxaB3RKaI1Pk2fDPU1H e5QJ2CQgLVxPmHeGv/W1mJSV8mrYdvDv6T+IcDQdX/3tEIfkav+cgqiwm4ZiFIgNokZe yBUMbUGGc9x7RGriiPtWmqmXh3ffNy6MJqoLOHbClBvzuGM++QaAcBDVKMHvMpGLdmhS JfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+RAofBvF7PXUkOEwV8bOjl0vZgfzh3tQd0a74lClFHk=; b=QQc2fHk6pc0/0eLWFlGbCWisiZQa7xfl8NRUYv5DUjvsybFmjyEYBfy/To0addEvZp JM6Bsjvf1c2So1XRWT5/xmwZ4llhUT5RNjI50S5bdjhPGj/w7CpGrB+xLDQRObGiP2hh cSqq69Va8r2l2UPgeKhSgPlXFuOtG+q2dwucQRs79NWKWUyd7nIS/2Bn8z6SW38J35ht Z2fL714t1NRjw2Ceb4LFW6m36fEr3WSHSi9ij1LiGvCQe9H/Bd6JA2ZnxOvozckDxdJ5 poQr8blHsGs8lGsbahqB6eDolHD0wfwC/4uIIh7rD5EIc5a4P8jaVwXHBs7ascY4hEZ7 WAtA== X-Gm-Message-State: AOAM530HBTYCq9WAK8Mam8Hf8EoQXAIzQhM8sjXw7z1MpScVhIVZd7RL yh485aMjpHw6NlEFw/xVcH47Fg60bSFeD7tHl06AU5R6YDE= X-Google-Smtp-Source: ABdhPJxl24Qf+yEr/q+wd82F2bcMMDmPdxUsT0dtVAC0cAF1AHWYKses98J8bc3ltRf1kN9cC8mp7seL9Jd7rpdXAes= X-Received: by 2002:a67:ec12:0:b0:349:e09e:da0c with SMTP id d18-20020a67ec12000000b00349e09eda0cmr10848035vso.27.1654367935264; Sat, 04 Jun 2022 11:38:55 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 4 Jun 2022 12:38:44 -0600 Message-ID: Subject: Re: panic: make_dev_alias_v: bad si_name To: Yuri Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="0000000000001c0fe805e0a38d90" X-Rspamd-Queue-Id: 4LFpS00b81z3w65 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=toddpk7n; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::e2a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.983]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; SH_EMAIL_DBL_DONT_QUERY_IPS(0.00)[0.0.0.1:email,0.0.0.0:email]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; DBL_PROHIBIT(0.00)[0.0.0.1:email,0.0.0.0:email]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e2a:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[current]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --0000000000001c0fe805e0a38d90 Content-Type: text/plain; charset="UTF-8" On Sat, Jun 4, 2022, 11:13 AM Yuri wrote: > Getting the following panic on HPE system with HPE enclosure: > > panic: make_dev_alias_v: bad si_name (error=22, > si_name=enc@n....../type@0/slot@1/elmdesc@{"Name":"DriveBay1"}/pass4) > > db_trace_self_wrapper() > vpanic() > panic() > make_dev_alias_v() > make_dev_alias_p() > make_dev_physpath_alias() > pass_add_physpath() > taskqueue_run_locked() > taskqueue_thread_loop() > fork_exit() > fork_trampoline() > > I have skipped typing all the frame information as the cause of panic > seems to be apparent -- enclosure replies with "Name":"DriveBay1" via > ses (it does the same weirdness for sensors and other elements), and > make_dev_alias_v() does not like the double quotes. Probably we need to > sanitize the input somewhere? > Likely. I'll take a look. Can you file a bug, include CAM in the title and cc imp@ please? Warner > --0000000000001c0fe805e0a38d90 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Jun 4, 2022, 11:13 AM Yuri <yuri@aetern.org> wrote:
Getting the following panic on HPE system with HPE enclosur= e:

panic: make_dev_alias_v: bad si_name (error=3D22,
si_name=3Denc@n....../type@0/slot@1/elmdesc@{"Name":"DriveBa= y1"}/pass4)

db_trace_self_wrapper()
vpanic()
panic()
make_dev_alias_v()
make_dev_alias_p()
make_dev_physpath_alias()
pass_add_physpath()
taskqueue_run_locked()
taskqueue_thread_loop()
fork_exit()
fork_trampoline()

I have skipped typing all the frame information as the cause of panic
seems to be apparent -- enclosure replies with "Name":"Drive= Bay1" via
ses (it does the same weirdness for sensors and other elements), and
make_dev_alias_v() does not like the double quotes.=C2=A0 Probably we need = to
sanitize the input somewhere?


Likely.=C2=A0 I= 9;ll take a look. Can you file a bug, include CAM in the title and cc imp@ = please?

Warner=C2=A0
--0000000000001c0fe805e0a38d90--