Date: Sat, 11 Mar 2017 17:50:21 -0800 From: Conrad Meyer <cem@freebsd.org> To: Marcelo Araujo <araujo@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315049 - head/usr.bin/vmstat Message-ID: <CAG6CVpUNgKLEUeXLGDmgXzUin=5uzo0%2Br5xq0XPjDzTvZR0gvQ@mail.gmail.com> In-Reply-To: <201703110436.v2B4aF6Z037011@repo.freebsd.org> References: <201703110436.v2B4aF6Z037011@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Marcelo, Should we add WARNS=2 in vmstat's Makefile so that developers notice when they break warnings at that level? Thanks, Conrad On Fri, Mar 10, 2017 at 8:36 PM, Marcelo Araujo <araujo@freebsd.org> wrote: > Author: araujo > Date: Sat Mar 11 04:36:15 2017 > New Revision: 315049 > URL: https://svnweb.freebsd.org/changeset/base/315049 > > Log: > Bring back the cast removed in my previous commit to allow us build vmstat > with WARNS 2. This cast was first introduced at r87690. > > Reported by: bde, pfg and ngie > MFC after: 3 weeks. > > Modified: > head/usr.bin/vmstat/vmstat.c > > Modified: head/usr.bin/vmstat/vmstat.c > ============================================================================== > --- head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:03:13 2017 (r315048) > +++ head/usr.bin/vmstat/vmstat.c Sat Mar 11 04:36:15 2017 (r315049) > @@ -288,13 +288,13 @@ retry_nlist: > namelist[X_SUM].n_name = "_cnt"; > goto retry_nlist; > } > - for (c = 0; c < nitems(namelist); c++) > + for (c = 0; c < (int)(nitems(namelist)); c++) > if (namelist[c].n_type == 0) > bufsize += strlen(namelist[c].n_name) + 1; > bufsize += len + 1; > buf = bp = alloca(bufsize); > > - for (c = 0; c < nitems(namelist); c++) > + for (c = 0; c < (int)(nitems(namelist)); c++) > if (namelist[c].n_type == 0) { > xo_error(" %s", > namelist[c].n_name); >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUNgKLEUeXLGDmgXzUin=5uzo0%2Br5xq0XPjDzTvZR0gvQ>