Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jun 2024 01:23:06 GMT
From:      "Jason E. Hale" <jhale@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: c3fbd9e60736 - main - multimedia/musikcube: Prepare for Taglib 2.x
Message-ID:  <202406070123.4571N6WN019669@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhale:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3fbd9e607364a20f141c4dc8dac7334f93a4a94

commit c3fbd9e607364a20f141c4dc8dac7334f93a4a94
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-06-06 21:29:17 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-06-06 23:01:06 +0000

    multimedia/musikcube: Prepare for Taglib 2.x
    
    PR:             276677
---
 ...-src_plugins_taglib__plugin_TaglibMetadataReader.cpp | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/multimedia/musikcube/files/patch-src_plugins_taglib__plugin_TaglibMetadataReader.cpp b/multimedia/musikcube/files/patch-src_plugins_taglib__plugin_TaglibMetadataReader.cpp
new file mode 100644
index 000000000000..15339eb97701
--- /dev/null
+++ b/multimedia/musikcube/files/patch-src_plugins_taglib__plugin_TaglibMetadataReader.cpp
@@ -0,0 +1,17 @@
+Fix build with Taglib 2.x.
+
+Deprecated member function MP4::Tag::itemListMap() was removed.
+
+https://github.com/clangen/musikcube/issues/670
+
+--- src/plugins/taglib_plugin/TaglibMetadataReader.cpp.orig	2023-09-11 02:03:12 UTC
++++ src/plugins/taglib_plugin/TaglibMetadataReader.cpp
+@@ -320,7 +320,7 @@ bool TaglibMetadataReader::ReadGeneric(
+             if (!handled) {
+                 const auto mp4File = dynamic_cast<TagLib::MP4::File*>(file.file());
+                 if (mp4File && mp4File->hasMP4Tag()) {
+-                    auto mp4TagMap = static_cast<TagLib::MP4::Tag*>(tag)->itemListMap();
++                    auto mp4TagMap = static_cast<TagLib::MP4::Tag*>(tag)->itemMap();
+                     this->ExtractValueForKey(mp4TagMap, "aART", "album_artist", target);
+                     this->ExtractValueForKey(mp4TagMap, "disk", "disc", target);
+                     this->ExtractReplayGain(mp4TagMap, target);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202406070123.4571N6WN019669>