From owner-svn-src-head@FreeBSD.ORG Thu Mar 3 19:34:09 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E261106564A; Thu, 3 Mar 2011 19:34:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D88818FC17; Thu, 3 Mar 2011 19:34:08 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 798A746B35; Thu, 3 Mar 2011 14:34:08 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.10]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0C2CB8A01B; Thu, 3 Mar 2011 14:34:08 -0500 (EST) From: John Baldwin To: Nathan Whitehorn Date: Thu, 3 Mar 2011 14:32:36 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; ) References: <201103021606.p22G6vou020460@svn.freebsd.org> <201103031209.43857.jhb@freebsd.org> <4D6FCE64.3010302@freebsd.org> In-Reply-To: <4D6FCE64.3010302@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103031432.36336.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 03 Mar 2011 14:34:08 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219181 - head/release X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2011 19:34:09 -0000 On Thursday, March 03, 2011 12:22:44 pm Nathan Whitehorn wrote: > On 03/03/11 11:09, John Baldwin wrote: > > On Wednesday, March 02, 2011 11:06:57 am Nathan Whitehorn wrote: > >> Author: nwhitehorn > >> Date: Wed Mar 2 16:06:57 2011 > >> New Revision: 219181 > >> URL: http://svn.freebsd.org/changeset/base/219181 > >> > >> Log: > >> Add additional release makefile for bsdinstall-based media, along with > >> support files. This does not change the default behavior of anything. > >> > >> To make bsdinstall-based media, pre-build world and GENERIC, then run > >> the release target in Makefile.bsdinstall. > > Are you planning on keeping the current 'make release' behavior of building a > > full chroot and doing a clean build in the chroot to build a release? That > > is, is 'Makefile.bsdinstall' just a temporary shortcut for building test > > releases or is that the final replacement for 'release/Makefile'? > > It was intended (modulo memstick building, docs, and some miscellaneous > cleanup) to be the final replacement for release/Makefile. In my > experience, the automatic fetching, clean build, and chroot was a major > impediment to easily making installation media for users to test > patches. I figured that if people (e.g. re@) really want a totally clean > tree, checking one out by hand and building from there didn't seem like > an enormous obstacle. > > If you think it's a really important feature, I'm happy to add it back, > however. I think it is a very important feature to ensure release builds are not polluted by local changes in /etc/src.conf, etc. I think it would be good to support both models perhaps, but for our official release builds I think we need the clean environment. I certainly use 'make release' now for my own custom FooBSD builds to get a clean environment. -- John Baldwin