From owner-freebsd-hackers  Sat Nov  1 08:52:25 1997
Return-Path: <owner-freebsd-hackers>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id IAA26899
          for hackers-outgoing; Sat, 1 Nov 1997 08:52:25 -0800 (PST)
          (envelope-from owner-freebsd-hackers)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA26894
          for <hackers@FreeBSD.ORG>; Sat, 1 Nov 1997 08:52:22 -0800 (PST)
          (envelope-from root@implode.root.com)
Received: from implode.root.com (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with ESMTP id IAA03064;
	Sat, 1 Nov 1997 08:53:14 -0800 (PST)
Message-Id: <199711011653.IAA03064@implode.root.com>
To: nnd@itfs.nsk.su
cc: hackers@FreeBSD.ORG
Subject: Re: Cyclades :( 
In-reply-to: Your message of "01 Nov 1997 08:23:22 GMT."
             <63eotq$37v@news.itfs.nsk.su> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Sat, 01 Nov 1997 08:53:14 -0800
Sender: owner-freebsd-hackers@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>	Driver's text inspection shows that there is ONLY ONE
>significant difference with 'standard FreeBSD's' cy-driver:
>(this is a 'diff -bu' result for /sys/i386/isa/cy.c version
>1.55 of 1997/09/21)
>
>--- cy.c.ORIG	Sat Nov  1 13:33:19 1997
>+++ cy.c	Sat Nov  1 13:36:55 1997
>@@ -410,7 +404,7 @@
> #endif
> 
> static	int	cy_chip_offset[] = {
>-	0x0000, 0x0200, 0x0400, 0x0600, 0x0100, 0x0300, 0x0500, 0x0700,
>+	0x0000, 0x0400, 0x0800, 0x0c00, 0x0200, 0x0600, 0x0a00, 0x0e00
> };
> static	int	cy_nr_cd1400s[NCY];
> static	int	cy_total_devices;
>
>
>	Can someone with Cyclom-8/16YeP (and problems ;-)
>test this patch ? I myself can not test it because my only ONE
>Cyclom-16YeP now busily serves 12 modems on Linux box.
>
>	Partial "correctnes proof" for this patch can be found
>in (working) Linux 'cy' (or 'cz') driver which uses the same
>chip_offset addresses as in "patched" driver, but not as in
>original FreeBSD's 'cy' driver.

   If you look at the cy_inb/cy_outb functions in cyreg.h, you'll see that
the offset is adjusted (shifted left by one bit) for the PCI card, making
the appropriate adjustment. The above change (which has the left shift built
in to the numbers) would effectively double this shift. What I'm saying is
that unless I'm really missing something, the patch can't be correct.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project