From owner-svn-src-head@freebsd.org Thu May 3 19:38:21 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D743FB78E6; Thu, 3 May 2018 19:38:21 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C2A16E54A; Thu, 3 May 2018 19:38:20 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-wm0-f46.google.com with SMTP id a137-v6so4223713wme.1; Thu, 03 May 2018 12:38:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+Tzv6K1bZQRRiP50d/xHwc1Nyn+dC55xxULzP+qhS+4=; b=RpIIy9aBUQnRACQ+5XeNApRuhphkq8syxNmwD6n7BR0jEkaC2nZsXdgH4ryejatEC0 FNuP5j4Srj+J0WfMdSywcHK8cfZslPy4X9vFQ7G4g3aga42ezf3pTTfqqAUb5pgsCQ2T nag0WjrrZsvLxggOXz4V/uBWcl8gTvdWJrBROlMfHTXbik0U7dHVmy3BIv78sOpbA579 /ECc+hTZvqAeuQm5VIJuUeF+a+AQHs4uUK8f2JIBkHbMbvr1QqGxyW+SYRoaBuTI399w /4iLHFmKd0t+LVGQgPOi8i7fipZfpKS/qq6p8DmexkjxqDQlJz0uoz7ax04GxjWEK2Z0 uh2Q== X-Gm-Message-State: ALQs6tCCXzPNFrm8SHgylEsQAL4KxKET1WwhGYuLViZ9UWigP+qREDbh ooitVx1/mNprRpgHgqyis1vUJkUN X-Google-Smtp-Source: AB8JxZprsxsyLabI5awzLVLjfOSaZ7kWbkVBzuIhUfOsXDhgIUy2hJpGrMp0JUUEwBxJJlEBBOYV5g== X-Received: by 2002:a50:8e59:: with SMTP id 25-v6mr5734060edx.101.1525376294267; Thu, 03 May 2018 12:38:14 -0700 (PDT) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com. [209.85.128.180]) by smtp.gmail.com with ESMTPSA id b16-v6sm8030827eds.81.2018.05.03.12.38.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 12:38:13 -0700 (PDT) Received: by mail-wr0-f180.google.com with SMTP id v5-v6so18780474wrf.9; Thu, 03 May 2018 12:38:13 -0700 (PDT) X-Received: by 2002:adf:ab56:: with SMTP id r22-v6mr20353972wrc.228.1525376293651; Thu, 03 May 2018 12:38:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.197.74 with HTTP; Thu, 3 May 2018 12:38:13 -0700 (PDT) In-Reply-To: <201805031501.w43F1Reo024234@repo.freebsd.org> References: <201805031501.w43F1Reo024234@repo.freebsd.org> From: "Jonathan T. Looney" Date: Thu, 3 May 2018 15:38:13 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333211 - head/sys/netinet/cc To: Sean Bruno Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 19:38:21 -0000 On Thu, May 3, 2018 at 11:01 AM, Sean Bruno wrote: > > @@ -242,8 +241,8 @@ tf_cwnd(int ticks_since_cong, int rtt_ticks, unsigned > { > > /* Equation 4 of I-D. */ > - return (((wmax * CUBIC_BETA) + (((THREE_X_PT2 * ticks_since_cong * > - smss) << CUBIC_SHIFT) / TWO_SUB_PT2 / rtt_ticks)) >> CUBIC_SHIFT); > + return (((wmax * CUBIC_BETA) + (((THREE_X_PT3 * ticks_since_cong * > + smss) << CUBIC_SHIFT) / TWO_SUB_PT3 / rtt_ticks)) >> CUBIC_SHIFT); > } > > #endif /* _NETINET_CC_CUBIC_H_ */ > Did you analyze this to ensure that the intermediate steps in this calculation would never overflow? Jonathan