From owner-svn-src-head@freebsd.org Thu Dec 14 16:01:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 412FCE8511E; Thu, 14 Dec 2017 16:01:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C415069EDC; Thu, 14 Dec 2017 16:00:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vBEG0lpU051718 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 14 Dec 2017 18:00:51 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vBEG0lpU051718 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id vBEG0lxU051712; Thu, 14 Dec 2017 18:00:47 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 14 Dec 2017 18:00:47 +0200 From: Konstantin Belousov To: Eugene Grosbein Cc: John Baldwin , Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326758 - in head/sys/i386: conf include Message-ID: <20171214160047.GL2272@kib.kiev.ua> References: <4a9c76c9-8063-9420-b198-14487b089840@FreeBSD.org> <5A30378A.3040609@grosbein.net> <5A3261BD.5050404@grosbein.net> <20171214115149.GC2272@kib.kiev.ua> <5A3268E9.506@grosbein.net> <20171214122659.GF2272@kib.kiev.ua> <5A327597.3010300@grosbein.net> <20171214152324.GJ2272@kib.kiev.ua> <5A329B26.9040504@grosbein.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A329B26.9040504@grosbein.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 16:01:00 -0000 On Thu, Dec 14, 2017 at 10:39:18PM +0700, Eugene Grosbein wrote: > On 14.12.2017 22:23, Konstantin Belousov wrote: > > >>> Sigh. This would make i386 even less usable for everybody, perhaps > >>> except you. Because default 3G of UVA is too small for some common tasks > >>> (thanks clang, but also e.g. pypy), and you reduce the user address > >>> space even more. > >> > >> Those who need 3GB of UVA within single process should not use 32 bit system in first place, should they? > > > > Why do you even consider it acceptable to break the configuration just > > because you are not interested in the workload ? > > I do not consider it is acceptable. I'm trying to find compromise. If you do not find the proposed change acceptable, why do you propose it at all ? > > > 3G cumulative VA does not translate into 3G of usable addresses: the bss > > is reserved, the address space is fragmented due to need of growing > > stack to not conflict with mmaped regions. As result, applications get > > slightly less than 2G usable without tricks, and to apply the tricks > > apps must know details of the AS layout, i.e. breaking the portability. > > > > 386 arch configuration is not perfect but it provides the main intended > > service of general-purpose workstation, with some limitation caused by > > 32bit of address space being somewhat low for modern code. Appliance > > flavoring of the default 386 config is unacceptable. Keep your tweaks > > local. > > Do you think that kstack overflow of general-purpose workstation using NFS > or IPv6 or WiFi with SCTP is OK? I do not. Kernel stack overflow is not 'OK', but two things are equally troublesome: - papering over the problem of large structures allocated on stack by increasing the stack size; - ignoring the explanation why the stack increase is problematic by itself and generating thread consisting of 50+ content-less messages claiming that 'it fixes the problem for me'. The proper route to fix the issues was already explained more than several times, and you (and I, and other people) participated in the ongoing efforts there. If it is so much important to you, wave the flag and herd the action, by asking relevant people to help with fixes, be it writing the patches, providing reviews or just finding the place where the stack is abused. It requires identification and time to think and develop specific changes for each place, and cannot happen in one day. But it also would not break KVA-starved architectures and provide fixes relevant to even KVA-ample machines, as you other example shown. For the case of extreme use, there is still the tunable (and ZFS on i386 is extreme).