From owner-cvs-all@FreeBSD.ORG  Thu Nov 25 01:31:18 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 4E57C1065670; Thu, 25 Nov 2010 01:31:18 +0000 (UTC)
Date: Thu, 25 Nov 2010 01:31:18 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Koop Mast <kwm@FreeBSD.org>
Message-ID: <20101125013118.GA39972@FreeBSD.org>
References: <201011242106.oAOL6A3r006192@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201011242106.oAOL6A3r006192@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/glib20 Makefile
	ports/devel/glib20/files extra-arch-powerpc64
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Nov 2010 01:31:18 -0000

On Wed, Nov 24, 2010 at 09:06:10PM +0000, Koop Mast wrote:
> kwm         2010-11-24 21:06:10 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     devel/glib20         Makefile 
>   Added files:
>     devel/glib20/files   extra-arch-powerpc64 
>   Log:
>   Due to a flaw in binutils 2.15, function names can conflict with
>   ELF assembler directives on PPC64 systems. As a result, it is not possible
>   to have functions named things like 'text' and 'data'.
>   In glib-compile-schemas.c we have such a name.

Why was it made a conditional extra patch instead of correctly patching
it across the gang with corresponding comment?  This is just one little
static function.  Also, the patch should be submitted upstream (was it?).

Another thing is that ${.CURDIR}/files should probably be ${FILESDIR}
in this context.

./danfe