From nobody Tue Dec 9 16:40:47 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dQl341sCZz6J9rF for ; Tue, 09 Dec 2025 16:40:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dQl335DYJz3Lsx for ; Tue, 09 Dec 2025 16:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765298447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jOZtZU9n9YFJnVqpMzhyx15ZWspbKkKnkX8w709oPLU=; b=InAkI8aqoTmKZlW0fmOztA9AgI0fAfSStNfCZlRwi2agonl8tK68g0VgG+XkAlEQzmWXJi xvai4xPG9fluDlpsXX2l4n0P8oL8oL/4BUEnKxf7ILLcIfkcYzcTTBgfJZNVzx8jfVDLBI hs0JxQW9/pbfSbcKCMpaIO/Rp4NRvOMDr7RdolfPuriF5RTVJyu0elVT1uMjiWY6X8RI8k Mx8vAUK7P54hV/macT8xnHBUSeW9B0OPqmL1yC1/2hLzc27FZaNGN4HPS85kXpi4zHdLbI Gs8D0UEJ9eiv8g1RJbVCUQt2yio4NZc+FAWuseonCBMXKxIyHjcFqBRKl60yPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765298447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jOZtZU9n9YFJnVqpMzhyx15ZWspbKkKnkX8w709oPLU=; b=xfQqXn50KipSIKSCClFzfOEvBBEhatSx9Ama1r5ymdk3zkPVFJXRmy0lTrIzqcudPiDbaX AIkUX7p0oDFzLwDZKfwfMhed8lraTghVjgThj5KqXJa+UtjwM1mAaL6lc4MCK1VsJHwDf0 KV8yuosL+g2CdxCoVJP2IDgNa+Z4Mj1Ov8G1wGGhgH2fkyDA//TkONrsEKdoCyRjfb8zrO OqMmmR61v0RaeyiwcMMhE0OetrEfuRrjcZFAV2pqfc9kF2w60Kas9Vwnvc/2AUqZt0g+4H gs7/jjzl2mm1nK7JxHo94DJVm3XKRTHcMn1Ihg1ryhOe44Hb/neC5zDphUa8Tg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765298447; a=rsa-sha256; cv=none; b=Pb/1xZetTtC+o7Hlslw0JAF/HT4GGPisJish37f6NI5Qu/wN5Gs6Da7hGOM+dX2USKty8R o9fzfv+Wt6aFmcthpm9SZbgXNbeYL/aD+1pc/UBqKOvsR2GYaxtLrUmZvIXm9x89cYtcve 4zMQXtmGi90xqZHwu6EwWORTjm31XmVWayqsfJn9X4GAzzK/EXqktqsJWTE2caAo6EI7Zw heHU4ohzKbRoBUrYjXh4AJLq4/EerElQgoBgbDMG3KVlimnuIAPigSIJvwx9y7K89icPsb yt7ACXs4iYKo0OaQhsc6ewGhih7AeO88pSAS4dtPfDgGqn4lsxhl4A11msh+4w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dQl334Xwpz165j for ; Tue, 09 Dec 2025 16:40:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 95c8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Dec 2025 16:40:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 63b77ab1554e - stable/14 - kgssapi: Remove broken MOD_UNLOAD code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 63b77ab1554eb642ad28c35339f08ccfeaab13e5 Auto-Submitted: auto-generated Date: Tue, 09 Dec 2025 16:40:47 +0000 Message-Id: <6938510f.95c8.69d7790a@gitrepo.freebsd.org> The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=63b77ab1554eb642ad28c35339f08ccfeaab13e5 commit 63b77ab1554eb642ad28c35339f08ccfeaab13e5 Author: Ed Maste AuthorDate: 2025-11-27 16:44:08 +0000 Commit: Ed Maste CommitDate: 2025-12-09 16:40:33 +0000 kgssapi: Remove broken MOD_UNLOAD code The module panicked at unload with "recursing but non-recursive rw". There is a comment that "Unloading of the kgssapi module is not currently supported" and the MOD_UNLOAD case falls through to returning EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it as a hint in case someone implements unload support later on. PR: 291249 Reviewed by: rmacklem Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53949 (cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460) (cherry picked from commit ab4f4f4efaac85bbf235e60f2ced4876a9e916f2) --- sys/kgssapi/gss_impl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kgssapi/gss_impl.c b/sys/kgssapi/gss_impl.c index ae37cb646f1f..f4b09749fdef 100644 --- a/sys/kgssapi/gss_impl.c +++ b/sys/kgssapi/gss_impl.c @@ -78,12 +78,14 @@ kgss_load(void) return (0); } +#if 0 static void kgss_unload(void) { syscall_helper_unregister(gssd_syscalls); } +#endif int sys_gssd_syscall(struct thread *td, struct gssd_syscall_args *uap) @@ -344,8 +346,10 @@ kgssapi_modevent(module_t mod, int type, void *data) error = kgss_load(); break; case MOD_UNLOAD: +#if 0 kgss_unload(); mtx_destroy(&kgss_gssd_lock); +#endif /* * Unloading of the kgssapi module is not currently supported. * If somebody wants this, we would need to keep track of