Date: Thu, 29 Jan 2015 09:36:58 -0800 From: Davide Italiano <davide@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277877 - head/lib/libc/mips/gen Message-ID: <CACYV=-Fv7TsptTB8SUM298Rqzs_8JmYe-4JSpHcg=wby1yiqsQ@mail.gmail.com> In-Reply-To: <201501291530.t0TFU5Qb077741@svn.freebsd.org> References: <201501291530.t0TFU5Qb077741@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 29, 2015 at 7:30 AM, Ed Maste <emaste@freebsd.org> wrote: > Author: emaste > Date: Thu Jan 29 15:30:04 2015 > New Revision: 277877 > URL: https://svnweb.freebsd.org/changeset/base/277877 > > Log: > Use zero register instead of immediate 0x0 in MIPS assembly > > It seems GAS makes the substitution automatically, but Clang's > integrated assembler does not (yet). It fails with "invalid operand for > instruction." > > Reported by: sbruno > > Modified: > head/lib/libc/mips/gen/sigsetjmp.S > > Modified: head/lib/libc/mips/gen/sigsetjmp.S > ============================================================================== > --- head/lib/libc/mips/gen/sigsetjmp.S Thu Jan 29 14:23:31 2015 (r277876) > +++ head/lib/libc/mips/gen/sigsetjmp.S Thu Jan 29 15:30:04 2015 (r277877) > @@ -61,7 +61,7 @@ __FBSDID("$FreeBSD$"); > LEAF(sigsetjmp) > PIC_PROLOGUE(sigsetjmp) > > - bne a1, 0x0, 1f # do saving of signal mask? > + bne a1, zero, 1f # do saving of signal mask? > PIC_TAILCALL(_setjmp) > > 1: PIC_TAILCALL(setjmp) > Ed, did you open a bug for this on LLVM bugzilla? If yes, can you please link it here, for the records? -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-Fv7TsptTB8SUM298Rqzs_8JmYe-4JSpHcg=wby1yiqsQ>