From owner-freebsd-fs@FreeBSD.ORG Thu Mar 11 13:08:16 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61DD4106566B for ; Thu, 11 Mar 2010 13:08:16 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id A19898FC14 for ; Thu, 11 Mar 2010 13:08:15 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 103FB45C9B; Thu, 11 Mar 2010 14:08:13 +0100 (CET) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 4EA0E45683; Thu, 11 Mar 2010 14:08:08 +0100 (CET) Date: Thu, 11 Mar 2010 14:08:07 +0100 From: Pawel Jakub Dawidek To: Michiel Detailleur Message-ID: <20100311130807.GJ2350@garage.freebsd.pl> References: <4B97A963.9040300@scoutsengidsenvlaanderen.be> <20100310174411.GE1715@garage.freebsd.pl> <4B98E95B.90806@scoutsengidsenvlaanderen.be> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ublo+h3cBgJ33ahC" Content-Disposition: inline In-Reply-To: <4B98E95B.90806@scoutsengidsenvlaanderen.be> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: [Spam? ] Re: ZFS snapshot name length limit? (File name too long) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 13:08:16 -0000 --Ublo+h3cBgJ33ahC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 11, 2010 at 02:00:11PM +0100, Michiel Detailleur wrote: > >From looking at the code, I think you hitting this limit: > > > >This is FreeBSD limit caused by statfs structure: > > > >/* > > * filesystem statistics > > */ > >[...] > >#define MNAMELEN 88 /* size of on/from name bufs */ > >[...] > > > >ZFS mounts snapshots on lookup and this is this mount that fails. > > =20 > So all that would need to be done to allow mounting snapshots with=20 > longer names would be to increase this value? (I'm not a C programmer,=20 > so bear with me :) ) Such change will break ABI compatibility with tools compiled on previous FreeBSD versions. As you can see in sys/sys/mount.h this is the reason we still keep ostatfs structure. I'll discuss the possibilities with other FreeBSD committers and we will see what we can do about it. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Ublo+h3cBgJ33ahC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkuY6zcACgkQForvXbEpPzTzCgCgpzZjbPw4RrG3VuSllVOzjzW9 J68AoKH4Lfqg2DZ06R4psYAb0ESuhXpE =ZnVM -----END PGP SIGNATURE----- --Ublo+h3cBgJ33ahC--