From owner-p4-projects@FreeBSD.ORG Fri Jan 4 01:25:42 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1B0C616A468; Fri, 4 Jan 2008 01:25:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D43E716A419; Fri, 4 Jan 2008 01:25:41 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id AE05F13C45B; Fri, 4 Jan 2008 01:25:41 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 70E2546F1F; Thu, 3 Jan 2008 20:25:41 -0500 (EST) Date: Fri, 4 Jan 2008 01:25:41 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Peter Wemm In-Reply-To: <200801032225.m03MPHAE060675@repoman.freebsd.org> Message-ID: <20080104012425.N42109@fledge.watson.org> References: <200801032225.m03MPHAE060675@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Perforce Change Reviews Subject: Re: PERFORCE change 132434 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 01:25:42 -0000 On Thu, 3 Jan 2008, Peter Wemm wrote: > http://perforce.freebsd.org/chv.cgi?CH=132434 > > Change 132434 by peter@peter_daintree on 2008/01/03 22:24:56 > > Export the build uuid to the dump header. Nothing interesting is done > with it at this point. > > While here, move all the mkdumpheader() copies into a MI place, as > the (duplicated) comment suggested. Allow magic numbers to be passed > through so textdumps can share the code too. Currently, I duplicate the panic string and kernel version string from the dump header in the textdump itself as data files. Any chance you want to do the same with the uuid? (Perhaps a better model would be to have savecore append another file to the textdump containing the header information, but the above seems to work fine for now, and has some advantages). Robert N M Watson Computer Laboratory University of Cambridge