From owner-svn-src-stable@freebsd.org Fri Jan 1 03:57:42 2016 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C280CA58140 for ; Fri, 1 Jan 2016 03:57:42 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 82857145E for ; Fri, 1 Jan 2016 03:57:42 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x233.google.com with SMTP id b14so99411676wmb.1 for ; Thu, 31 Dec 2015 19:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MHldRlDll4QTsWIOGP/GsqYes6n11/HNCb9UoBLUwWk=; b=JreS9IFE0kDHGQPGrSyhN28yUHoGfjaVskM84aKbs/EBVFOF28vXlth+n4LmSK8781 qRoPT5KFWiko0r2IQEc9tZfIpTO3D5/y7fMYHgUt3yJTM0ut4ZnotABguTWvYnxp/F+8 l0yzhVuz9ZUVzJFNYO/7minA47hNtkvt3QH8nAqXBlHxepbLZQmcJkEiaPTkfTnsrpnM qfecHEeshx8kMW4X4L8L+y+mVDY2MGVtWJkCRtGN+l00MH29kgTs24beGuM3+oObLCae qPcQ05WL8hXKnHzS25HY+/1D1gMddlwKeazBDd6eL/Vd7vfIzVVE+4iN0+/wo/YZ0ZSA Q6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=MHldRlDll4QTsWIOGP/GsqYes6n11/HNCb9UoBLUwWk=; b=BrYG+lKqrXL8rLsLsRgPiUxgtopMDA3JOzMD2dll07qeHmbo/oF5uJ8uUETuspM+Uo P8M327Y/bgthhlyZfAiPwkS+sQLxovQcUcvqX0sr85uL4xcjrXlgl34SBlNWOgxPHw+p KyuK6mPsaxrv4SkOn9Nek3tlqmd5xPxbh8dXF3Wi8mE9Fahj7jfvxhmee1J/kZjsCBkS DUMNEi7057bfyK6vrn0bdr352TWiNOULnAs0rabpGMPteGHgFEm1NzyMWHmJW3cKcNQn tLhaeuGYmIcEt6jbghQ/w7kBRbM6WvqrhKBNG7DMRgJRM82B20amEVBzcwQCicFOFHTB rBJA== X-Gm-Message-State: ALoCoQky5YDbocPktrKPqLI4JEhU8oyckW9utXxLZf586Q8toIiKXfh4RnNdEchgaFS3mfyCOLL7wC3kEGeIy/88njBgyGGTa4UaRhaypFONKFsaBmQ+XcM= MIME-Version: 1.0 X-Received: by 10.28.228.87 with SMTP id b84mr32100062wmh.81.1451620660873; Thu, 31 Dec 2015 19:57:40 -0800 (PST) Received: by 10.194.85.167 with HTTP; Thu, 31 Dec 2015 19:57:40 -0800 (PST) In-Reply-To: <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com> References: <201512310355.tBV3t2VG040656@repo.freebsd.org> <2893860.oDiG4KQizb@ralph.baldwin.cx> <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com> Date: Fri, 1 Jan 2016 04:57:40 +0100 Message-ID: Subject: Re: svn commit: r292975 - stable/10/sys/dev/pci From: Oliver Pinter To: NGie Cooper Cc: John Baldwin , "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "svn-src-stable-10@freebsd.org" , Garrett Cooper Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2016 03:57:43 -0000 On Thursday, December 31, 2015, NGie Cooper wrote: > > > On Dec 31, 2015, at 08:42, John Baldwin = > > wrote: > > > > On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote: > >> Author: ngie > >> Date: Thu Dec 31 03:55:02 2015 > >> New Revision: 292975 > >> URL: https://svnweb.freebsd.org/changeset/base/292975 > >> > >> Log: > >> MFC r278860: > >> r278860 (by jmg): > >> > >> remove NULL check as M_WAITOK will not return NULL > >> > >> Reviewed by: jhb > >> Sponsored by: FreeBSD Foundation > > > > Including the metadata from the HEAD commit in the MFC can be > misleading, and > > I think it is best ommitted. For example, I did not review this MFC (a= nd > > reviewing MFC's in their own right matters since they may require > additional > > work than commits to HEAD due to ABI concerns), nor did the Foundation > sponsor > > the MFC. Rather, I think MFCs should only specify metadata related to > the > > actual merge itself. > > Agreed. I=E2=80=99ve changed my mfc_log script to skip over some more unn= ecessary > svn log metadata: > https://github.com/yaneurabeya/scratch/commit/4f897efb96f96f951ff3909857f= 67e63b24b733a > . > Thanks :)! > -NGie It would be nice to commit this script under tools directory. > _______________________________________________ > svn-src-stable-10@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10 > To unsubscribe, send any mail to " > svn-src-stable-10-unsubscribe@freebsd.org "