From owner-freebsd-current@FreeBSD.ORG Fri Feb 27 19:11:13 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81889106566C; Fri, 27 Feb 2009 19:11:13 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 53F948FC19; Fri, 27 Feb 2009 19:11:13 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from [192.168.1.2] (adsl-1-207-68.bna.bellsouth.net [65.1.207.68]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n1RJ9o91028739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Feb 2009 14:09:50 -0500 (EST) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: John Baldwin In-Reply-To: <200902271403.46828.jhb@freebsd.org> References: <200902271730.07660.snasonov@bcc.ru> <200902271208.48212.jhb@freebsd.org> <1235760629.1289.51.camel@widget.2hip.net> <200902271403.46828.jhb@freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-mHc4t/tx+tLQuewSip8f" Organization: FreeBSD Date: Fri, 27 Feb 2009 13:11:04 -0600 Message-Id: <1235761864.1289.54.camel@widget.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 FreeBSD GNOME Team Port X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RCVD_IN_SORBS_DUL,RDNS_DYNAMIC autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-current@freebsd.org, Sergey G Nasonov Subject: Re: Interrupt stom on cardbus device X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2009 19:11:13 -0000 --=-mHc4t/tx+tLQuewSip8f Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2009-02-27 at 14:03 -0500, John Baldwin wrote: > On Friday 27 February 2009 1:50:28 pm Robert Noland wrote: > > On Fri, 2009-02-27 at 12:08 -0500, John Baldwin wrote: > > > On Friday 27 February 2009 9:30:06 am Sergey G Nasonov wrote: > > > > Hello all, > > > > I have get an issue after recent kernel recompile. > > > > The problem appears after switch from X to text console and back to= X11. > > > > After that vmstat -i show an interrupt storm on cardbus device: > > > >=20 > > > > > vmstat -i > > > > interrupt total rate > > > > irq1: atkbd0 6483 3 > > > > irq9: acpi0 3236 1 > > > > irq12: psm0 347988 167 > > > > irq14: ata0 16431 7 > > > > irq16: cbb0 uhci2+ 13624982 6556 > > > > irq20: uhci0 14 0 > > > > irq22: ehci0 2 0 > > > > cpu0: timer 4154687 1999 > > > > irq256: em0 53736 25 > > > > irq257: hdac0 5797 2 > > > > cpu1: timer 4153683 1998 > > > > irq258: vgapci0 235585 113 > > > > Total 22602624 10877 > > > >=20 > > > > I suppose that the issue related with the latest MSI interrupt=20 > > > > handler changes for intel graphics chipset. My laptop has i965GM. > > > > pciconf -lv: > > > >=20 > > > > vgapci0@pci0:0:2:0: class=3D0x030000 card=3D0x20b517aa chip=3D0= x2a028086=20 > > > > rev=3D0x0c hdr=3D0x00 > > > > vendor =3D 'Intel Corporation' > > > > device =3D 'Mobile 965 Express Integrated Graphics Controll= er' > > > > class =3D display > > > > subclass =3D VGA > > > >=20 > > > > When I added my device to drm_msi_blacklist and recompile drm modul= es=20 > the=20 > > > > problem disappear. > > > > Is it possible to resolve this problem without moving the device to= the=20 > > > > drm_msi_blacklist? > > > > I can test any patches or provide additional detail if it is requir= ed. =20 > > > > Thanks. > > >=20 > > > It seems the device is still interrupting on its INTx line perhaps in= =20 > addition=20 > > > to the MSI interrupts. > >=20 > > Hrm, I did most all of that development on a 965gm. When you VT switch= , > > the irq handler gets uninstalled and reinstalled when you return to X. > > There was an eratta on the 965gm suggesting that msi didn't work right, > > but I was never able to produce the issue. Intel was having major > > issues with this on linux and I finally convinced them to turn msi back > > on. My irq handler and Eric's are very similar, so I'm not sure what > > could be going on here. > >=20 > > There is however an issue with vblanks that might be related. Could yo= u > > try http://people.freebsd.org/~rnoland/drm-move_vblank_init.patch and > > see if that helps? >=20 > In this case the issue isn't that MSI isn't working I think, but that the= =20 > hardware is sending interrupts via both routes (MSI and INTx). If that=20 > happens, then you will see an interrupt storm on the INTx line, but FreeB= SD=20 > will only notice if another device is sharing the same IRQ line. So if y= our=20 > test machine has vgapci0 on irq 22 and you have no other devices on IRQ 2= 2,=20 > then the storm would go unnoticed. This is most likely a chip bug (unles= s=20 > the driver has to explicitly disable INTx interrupts when using MSI). It= =20 > would probably be a good idea to add a hw.drm.msi_enable tunable (or=20 > hw.drm.msi) that people can use to disable MSI perhaps. Ok, I do have docs on the 965, so I'll look at this. The linux version does not do this, unless the OS does it in the background somewhere. I thought about adding a tuneable, but I have to figure out how that works first... ;) robert. --=20 Robert Noland FreeBSD --=-mHc4t/tx+tLQuewSip8f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEABECAAYFAkmoOsgACgkQM4TrQ4qfROOkZwCeN2Pn0VVBqC90AFbuLXU7M16M qr0An3lt//Sxz0qBb36RII+jbVlPVG8O =hn9H -----END PGP SIGNATURE----- --=-mHc4t/tx+tLQuewSip8f--