From owner-svn-ports-all@FreeBSD.ORG  Sun Jun 29 21:19:46 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A2616B2C;
 Sun, 29 Jun 2014 21:19:46 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7F15B2A3E;
 Sun, 29 Jun 2014 21:19:46 +0000 (UTC)
Received: from [192.168.0.131] (vie-188-118-252-235.dsl.sil.at
 [188.118.252.235])
 by ainaz.pair.com (Postfix) with ESMTPSA id E26033F40F;
 Sun, 29 Jun 2014 17:19:34 -0400 (EDT)
Date: Sun, 29 Jun 2014 23:19:33 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: svn commit: r336343 - in head: . Mk/Uses
In-Reply-To: <201312131322.rBDDMWZC038800@svn.freebsd.org>
Message-ID: <alpine.LSU.2.11.1406292318140.30120@tuna.site>
References: <201312131322.rBDDMWZC038800@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jun 2014 21:19:46 -0000

On Fri, 13 Dec 2013, Tijl Coosemans wrote:
> Added: head/Mk/Uses/fortran.mk
> ==============================================================================
> +.if ${fortran_ARGS} == gcc
> +_GCC_VER=	46

We have already made this ${GCC_DEFAULT:S/.//}...

> +BUILD_DEPENDS+=	gfortran${_GCC_VER}:${PORTSDIR}/lang/gcc
> +RUN_DEPENDS+=	gfortran${_GCC_VER}:${PORTSDIR}/lang/gcc
> +USE_BINUTILS=	yes
> +F77=		gfortran${_GCC_VER}
> +FC=		gfortran${_GCC_VER}
> +FFLAGS+=	-Wl,-rpath=${LOCALBASE}/lib/gcc${_GCC_VER}
> +LDFLAGS+=	-Wl,-rpath=${LOCALBASE}/lib/gcc${_GCC_VER}

...but is there a way to avoid this duplication of logic in bsd.gcc.mk
(and Uses/compiler)?

This duplication worries me.

Gerald