From owner-p4-projects@FreeBSD.ORG  Tue Jan 31 01:23:27 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 392FF16A423; Tue, 31 Jan 2006 01:23:27 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ED21716A420
	for <perforce@freebsd.org>; Tue, 31 Jan 2006 01:23:26 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AFC5743D45
	for <perforce@freebsd.org>; Tue, 31 Jan 2006 01:23:26 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0V1NQ9u081465
	for <perforce@freebsd.org>; Tue, 31 Jan 2006 01:23:26 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0V1NQP4081462
	for perforce@freebsd.org; Tue, 31 Jan 2006 01:23:26 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Tue, 31 Jan 2006 01:23:26 GMT
Message-Id: <200601310123.k0V1NQP4081462@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 90753 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2006 01:23:28 -0000

http://perforce.freebsd.org/chv.cgi?CH=90753

Change 90753 by rwatson@rwatson_peppercorn on 2006/01/31 01:22:49

	Correct an inaccurate comment: we send audit log errors to the
	system log, not the audit log, for obvious reasons.
	
	Log errno information when exec() fails.
	
	Fix formatting.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/bin/auditd/audit_warn.c#3 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/bin/auditd/audit_warn.c#3 (text+ko) ====

@@ -37,7 +37,7 @@
 #include "auditd.h"
 
 /*
- * Write to the audit log.
+ * Write an audit-related error to the system log via syslog(3).
  */
 static int
 auditwarnlog(char *args[])
@@ -59,7 +59,8 @@
 		 * Child.
 		 */
 		execv(AUDITWARN_SCRIPT, loc_args);
-		syslog(LOG_ERR, "Could not exec %s\n", AUDITWARN_SCRIPT);
+		syslog(LOG_ERR, "Could not exec %s (%m)\n",
+		    AUDITWARN_SCRIPT);
 		exit(1);
 	}
 	/*
@@ -104,6 +105,7 @@
 /*
  * Indicates that someone other than the audit daemon turned off auditing.
  * XXX Its not clear at this point how this function will be invoked.
+ *
  * XXXRW: This function is not used.
  */
 int