From owner-svn-ports-all@FreeBSD.ORG Mon Mar 23 15:12:05 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF3583FE for ; Mon, 23 Mar 2015 15:12:05 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7D064BAE for ; Mon, 23 Mar 2015 15:12:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t2NFC5fT054202 for ; Mon, 23 Mar 2015 15:12:05 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t2NFC5PF054195 for svn-ports-all@freebsd.org; Mon, 23 Mar 2015 15:12:05 GMT (envelope-from bdrewery) Received: (qmail 56762 invoked from network); 23 Mar 2015 10:12:03 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 23 Mar 2015 10:12:03 -0500 Message-ID: <55102D45.4000404@FreeBSD.org> Date: Mon, 23 Mar 2015 10:12:05 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: marino@freebsd.org, Baptiste Daroussin Subject: Re: svn commit: r381955 - head/graphics/gdal References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> <5510234A.7040704@marino.st> <55102A1A.9000002@FreeBSD.org> <55102B5B.6040906@marino.st> <55102BE6.9030305@marino.st> In-Reply-To: <55102BE6.9030305@marino.st> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mLlUW23w4t9DrK7pJOUk1a61XTkVLwBB4" Cc: Sunpoet Po-Chuan Hsieh , svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 15:12:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mLlUW23w4t9DrK7pJOUk1a61XTkVLwBB4 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/23/2015 10:06 AM, John Marino wrote: > On 3/23/2015 16:03, John Marino wrote: >> On 3/23/2015 15:58, Bryan Drewery wrote: >>> On 3/23/2015 9:29 AM, John Marino wrote: >>>> On 3/23/2015 15:24, Bryan Drewery wrote: >>>>> -lpthread? Why not -lthr since -lpthread is actually an alias to th= at? >>>>> >>>> >>>> There is no libthr.so on DragonFly. That would break the port. >>>> >>> >>> I do understand that and do not want to break DragonFly. However, I s= ee >>> it as the same argument as converting -pthread to -lpthread. It's mor= e >>> of an example. >> >> >> We aren't adding the conversion of -pthread to -pthread; we are talkin= g >> about removing the conversion of -lpthread to -pthread. >> >> more specifically: we are talking about removing REINPLACE_CMD that >> replaces -lpthread, removing patches that replace -pthread, and removi= ng >> the use of PTHREAD_LIBS. >> >=20 > repeated with critical typo's fixed: > We aren't adding the conversion of -pthread to -lpthread; we are talkin= g > about removing the conversion of -lpthread to -pthread. >=20 > more specifically: we are talking about removing REINPLACE_CMD that > replaces -lpthread, removing patches that replace -lpthread, and > removing the use of PTHREAD_LIBS. >=20 > Sorry! >=20 Ok. I think I understand now. - @${REINPLACE_CMD} -e 's|-lpthread|-pthread|g' ${WRKSRC}/configure You want to just cleanup the needless replacements. The commit in question was -2 lines +1 line. So it is an improvement. I agree then with your plan as long as it is just cleaning up unneeded se= ds. --=20 Regards, Bryan Drewery --mLlUW23w4t9DrK7pJOUk1a61XTkVLwBB4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVEC1FAAoJEDXXcbtuRpfPbTcH/1xLyue4blrg1eKDJ4Ss/bka WMMA35edzjwFvbsCFASFBpeq1GE6ezPIJz3FuKwU+XX20TAOBN2QLOW5qrZot2Dx Gv0TrHFH/OcY6PkHV17kR6Vm3iYyyThRwKtTJFX5CdAbyZuXf0+A4jwhH6ArwKRH UkyydIOA4NzQ9fWduzZKqx0VqN62lF5nS2E3Aebi5cQs4nmxb4twN6QMzAPj6+jy vvHM7/rOWM/1X0aRKXSxz8+FIYzb+fQSRzo3NfePRWAFCK4Sm8q/j8vnAR7bC0gH tDY6kKvBrpZU4ehGZJOuXbPUte+7vE5T+O37+wgMvvkxN+qx/6IrR9DRAd3LQpY= =MPu+ -----END PGP SIGNATURE----- --mLlUW23w4t9DrK7pJOUk1a61XTkVLwBB4--