From owner-freebsd-bugs@FreeBSD.ORG Tue May 5 06:20:02 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A3301065673 for ; Tue, 5 May 2009 06:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C0F348FC12 for ; Tue, 5 May 2009 06:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n456K1su055970 for ; Tue, 5 May 2009 06:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n456K1Pt055969; Tue, 5 May 2009 06:20:01 GMT (envelope-from gnats) Resent-Date: Tue, 5 May 2009 06:20:01 GMT Resent-Message-Id: <200905050620.n456K1Pt055969@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eugene Mychlo Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5516A106566B for ; Tue, 5 May 2009 06:15:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 449A58FC1B for ; Tue, 5 May 2009 06:15:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n456Fhbj014363 for ; Tue, 5 May 2009 06:15:43 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n456FhsN014362; Tue, 5 May 2009 06:15:43 GMT (envelope-from nobody) Message-Id: <200905050615.n456FhsN014362@www.freebsd.org> Date: Tue, 5 May 2009 06:15:43 GMT From: Eugene Mychlo To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/134220: ng_netflow(4): incorrect comparison in ng_netflow_rcvmsg() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2009 06:20:02 -0000 >Number: 134220 >Category: kern >Synopsis: ng_netflow(4): incorrect comparison in ng_netflow_rcvmsg() >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 05 06:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Eugene Mychlo >Release: FreeBSD 7.2-RC2 >Organization: Rekomendata, JSC >Environment: FreeBSD mycws.local 7.2-RC2 FreeBSD 7.2-RC2 #0: Thu Apr 23 22:07:24 UTC 2009 root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: ng_netflow_rcvmsg() compare msg->header.arglen with sizeof(struct ng_netflow_settimeouts) instead of sizeof(struct ng_netflow_setconfig) when processing NGM_NETFLOW_SETCONFIG control message. >How-To-Repeat: >Fix: Patch attached with submission follows: --- sys/netgraph/netflow/ng_netflow.c (revision 191778) +++ sys/netgraph/netflow/ng_netflow.c (working copy) @@ -422,7 +422,7 @@ { struct ng_netflow_setconfig *set; - if (msg->header.arglen != sizeof(struct ng_netflow_settimeouts)) + if (msg->header.arglen != sizeof(struct ng_netflow_setconfig)) ERROUT(EINVAL); set = (struct ng_netflow_setconfig *)msg->data; >Release-Note: >Audit-Trail: >Unformatted: