From owner-cvs-all  Wed Nov 21  7:37:13 2001
Delivered-To: cvs-all@freebsd.org
Received: from noos.fr (r178m112.cybercable.tm.fr [195.132.178.112])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5334737B418; Wed, 21 Nov 2001 07:37:01 -0800 (PST)
Received: (from mux@localhost)
	by noos.fr (8.11.6/8.11.4) id fALFarW03603;
	Wed, 21 Nov 2001 16:36:53 +0100 (CET)
	(envelope-from mux)
Date: Wed, 21 Nov 2001 16:36:53 +0100
From: Maxime Henrion <mux@qualys.com>
To: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Cc: arr@FreeBSD.org, yar@FreeBSD.org, david@phobia.ms
Subject: Re: cvs commit: src/libexec/ftpd ftpd.c
Message-ID: <20011121163653.B916@nebula.noos.fr>
References: <200111192152.fAJLq3N94389@freefall.freebsd.org> <Pine.NEB.3.96L.1011119165508.75141B-100000@fledge.watson.org> <20011119190403.7cb2020b.david@phobia.ms>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011119190403.7cb2020b.david@phobia.ms>
User-Agent: Mutt/1.3.23i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

David Hill wrote:
> On Mon, 19 Nov 2001 17:00:51 -0500 (EST)
> "Andrew R. Reiter" <arr@FreeBSD.org> wrote:
> 
> > On Mon, 19 Nov 2001, Yar Tikhiy wrote:
> > 
> > :yar         2001/11/19 13:52:03 PST
> > :
> > :  Modified files:
> > :    libexec/ftpd         ftpd.c 
> > :  Log:
> > :  Eliminate another instance of the old and well-known
> > :  DoS bug that the select(2)/accept(2) pair is called on
> > :  a socket that is in the blocking I/O mode.  The bug is
> > :  triggered if a selected connection dies before the accept(2)
> > :  leading to the accept(2) blocking virtually forever.
> > :  
> > :  MFC after:      1 week
> > :  
> > :  Revision  Changes    Path
> > :  1.87      +25 -7     src/libexec/ftpd/ftpd.c
> > 
> > Just as a thought, since I've noted the ftpd mucking, there are two issues
> > with the ftp daemon code that are not necesarily critical, but should be
> > changed:
> >   - Dynamically allocate the fd_set bit arrays
> >   - Correct usage of signal handlers to only use set/check flags.
> > 
> > Got anymore motivation to tackle those? 
> > 
> > Cheers,
> > Andrew
> > 
> > --
> > Andrew R. Reiter
> > arr@watson.org
> > arr@FreeBSD.org
> 
> How about switching ftpd to use kqueue?
> 
> - David

What about /usr/src/contrib/lukemftpd ? :-)

Maxime
-- 
Don't be fooled by cheap finnish imitations ; BSD is the One True Code

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message