Date: Sun, 31 Mar 2013 11:27:29 -0400 From: Eitan Adler <eadler@freebsd.org> To: Chris Rees <crees@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org> Subject: Re: svn commit: r315623 - head/benchmarks/mdtest Message-ID: <CAF6rxg=bNAKNO_y8tQtv5e2uutjYhr07GtGA-O5gPc7Ni5cjbA@mail.gmail.com> In-Reply-To: <CADLo8383kQ4LYF4%2BOG6riKpF7xWrf7WAu1ELg6S8403B14H5-w@mail.gmail.com> References: <201303301854.r2UIsYxc030098@svn.freebsd.org> <51573566.4030303@FreeBSD.org> <CAF6rxg=Xgay=J=Jid=17iVH4XRaO8goraK7DMY7fuM1KN75dqA@mail.gmail.com> <CADLo8383kQ4LYF4%2BOG6riKpF7xWrf7WAu1ELg6S8403B14H5-w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 March 2013 05:28, Chris Rees <crees@freebsd.org> wrote: > On 31 March 2013 00:45, Eitan Adler <eadler@freebsd.org> wrote: >> On 30 March 2013 14:56, Bryan Drewery <bdrewery@freebsd.org> wrote: >>> On 3/30/2013 1:54 PM, Eitan Adler wrote: >>>> Author: eadler >>>> Date: Sat Mar 30 18:54:34 2013 >>>> New Revision: 315623 >>>> URL: http://svnweb.freebsd.org/changeset/ports/315623 >>>> >>>> Log: >>>> Distfile reroll: Checked against upstream sourceforge >>> >>> Would be helpful to know what changed in these type of commits. Just >>> because the upstream SF has a changed file doesn't mean it's OK to use. >> >> Agreed, but I could not find the old distfile to compare against. >> I'm aware of the issues involved. > > How could you be sure it's still OK? Please see your next line. > http://www.bayofrum.net/~crees/patches/mdtest-tarball-vs-cvs-experimental_1_8_3.diff > > This diff is against the latest code in CVS (the tag > experimental_1_8_3); it appears upstream isn't actually versioning > their code there any more. As I said, I checked against upstream. Normally I'd expect that without a version bump you check against the old distfile if available. Since I could not, I checked against the newest upstream version. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=bNAKNO_y8tQtv5e2uutjYhr07GtGA-O5gPc7Ni5cjbA>