From owner-svn-src-all@freebsd.org Tue Nov 22 19:42:08 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37DC7C501B3; Tue, 22 Nov 2016 19:42:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f177.google.com (mail-io0-f177.google.com [209.85.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04793E66; Tue, 22 Nov 2016 19:42:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f177.google.com with SMTP id j65so78692012iof.0; Tue, 22 Nov 2016 11:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=ahV5rCFvL+VBPWY5wA4inefwflwarR7/l4rTA4aHfbk=; b=SNbPuIcRCBrKTzgLGrromL2vgrnrMXYDL0pXedq5Tlg/z3keDWPz3KjwXNNqXn/wM9 W+ZclNvRR3QCd8dqR4caqWJ/iYlxsVsaw3QC32PF4Pg73zyT9kNQbEssetb0gfwKekwS KGkikObpXHv905egHrK7PeWANbbyMAyCo7hJvgTNEqsqrqTqv70oFG8E274w4dJ+sgt5 TAe74RfX8zewwRwS+PM8NCCYSfPBtqY3GxlOJjxxWXI/RYckpDxKUZxX3ruTesObDwCk ZMIzoUQjl3dHD+rERYEMlOXlUYarcWSW2EJ+iiRGIDXQnsf7+d00e+U5p7bwwR56A8IO bsVw== X-Gm-Message-State: AKaTC03xWEmkJz98jobKQjvylQ9qdUihB2ShXihEvCnQDhhNSW4oRsZNGMQRGdZkcwi/lg== X-Received: by 10.107.59.88 with SMTP id i85mr18589914ioa.198.1479838146989; Tue, 22 Nov 2016 10:09:06 -0800 (PST) Received: from mail-io0-f179.google.com (mail-io0-f179.google.com. [209.85.223.179]) by smtp.gmail.com with ESMTPSA id w192sm1150241itw.3.2016.11.22.10.09.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2016 10:09:06 -0800 (PST) Received: by mail-io0-f179.google.com with SMTP id a124so1293157ioe.2; Tue, 22 Nov 2016 10:09:06 -0800 (PST) X-Received: by 10.107.140.65 with SMTP id o62mr17826125iod.17.1479838146558; Tue, 22 Nov 2016 10:09:06 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.109.68 with HTTP; Tue, 22 Nov 2016 10:09:06 -0800 (PST) In-Reply-To: <201611152035.uAFKZTQB045021@repo.freebsd.org> References: <201611152035.uAFKZTQB045021@repo.freebsd.org> From: Conrad Meyer Date: Tue, 22 Nov 2016 10:09:06 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r308696 - in head: share/man/man4 sys/boot/forth sys/conf sys/dev/bnxt sys/modules sys/modules/bnxt To: Stephen Hurd Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2016 19:42:08 -0000 Hi Stephen, Coverity reports a missing 'break;' (or explicit /* FALLTHROUGH */) in if_bnxt.c:1915. (The HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKR cases flow into the HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASELR case.) CID is 1366223. If the fall-through is intentional, please add the comment. If it isn't, I guess it needs a break statement. Thanks, Conrad On Tue, Nov 15, 2016 at 12:35 PM, Stephen Hurd wrote: > Author: shurd (ports committer) > Date: Tue Nov 15 20:35:29 2016 > New Revision: 308696 > URL: https://svnweb.freebsd.org/changeset/base/308696 > > Log: > New driver for Broadcom NetXtreme-C and NetXtreme-E devices. > > This driver uses the iflib framework supporting Broadcom > 25/50Gbps devices. > > Reviewed by: gallatin, wblock > Approved by: davidch > MFC after: 2 weeks > Relnotes: yes > Sponsored by: Broadcom Limited > Differential Revision: https://reviews.freebsd.org/D7551 > > Added: > head/share/man/man4/bnxt.4 (contents, props changed) > head/sys/dev/bnxt/ > head/sys/dev/bnxt/bnxt.h (contents, props changed) > head/sys/dev/bnxt/bnxt_hwrm.c (contents, props changed) > head/sys/dev/bnxt/bnxt_hwrm.h (contents, props changed) > head/sys/dev/bnxt/bnxt_ioctl.h (contents, props changed) > head/sys/dev/bnxt/bnxt_sysctl.c (contents, props changed) > head/sys/dev/bnxt/bnxt_sysctl.h (contents, props changed) > head/sys/dev/bnxt/bnxt_txrx.c (contents, props changed) > head/sys/dev/bnxt/convert_hsi.pl (contents, props changed) > head/sys/dev/bnxt/hsi_struct_def.h (contents, props changed) > head/sys/dev/bnxt/if_bnxt.c (contents, props changed) > head/sys/modules/bnxt/ > head/sys/modules/bnxt/Makefile (contents, props changed) > Modified: > head/share/man/man4/Makefile > head/sys/boot/forth/loader.conf > head/sys/conf/NOTES > head/sys/conf/files > head/sys/modules/Makefile > > ... > > *** DIFF OUTPUT TRUNCATED AT 1000 LINES ***