From owner-freebsd-current@FreeBSD.ORG Thu Oct 11 18:34:38 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D96316A41A for ; Thu, 11 Oct 2007 18:34:38 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id BD88613C44B for ; Thu, 11 Oct 2007 18:34:37 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l9BIYZSj006190; Thu, 11 Oct 2007 14:34:35 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Thu, 11 Oct 2007 14:34:35 -0400 (EDT) Date: Thu, 11 Oct 2007 14:34:35 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Steve Kargl In-Reply-To: <20071011180815.GA23643@troutmask.apl.washington.edu> Message-ID: References: <20071011180815.GA23643@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: Removing a symbol from Symbol.map? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2007 18:34:38 -0000 On Thu, 11 Oct 2007, Steve Kargl wrote: > In my journey through the libm source code, I've discovered > that msun/src/w_cabs.c contains a function named z_abs. This > symbol appears in libm's Symbol.map, but z_abs has not prototype > in any header file under /usr/include. Thus, it is namespace > pollution that I'd like to remove. Do I simply remove z_abs from > Symbol.map or is there more to it then this? Nope, no more to it than just removing it from the symbol map. I certainly don't have any object to removing symbols that don't belong there. It should be MFC'd to -7 before release if it really shouldn't be there. If it doesn't make it to -7, then we'll need to keep it as a compatibility function forever. > PS: Yes, I know bde will probably object to removal of z_abs > because of compatibility issues with fdlibm and the other *BSD. -- DE