From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 9 10:30:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5758616A41B for ; Wed, 9 Jan 2008 10:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 309BA13C4EE for ; Wed, 9 Jan 2008 10:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m09AU2Zl041315 for ; Wed, 9 Jan 2008 10:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m09AU2V7041312; Wed, 9 Jan 2008 10:30:02 GMT (envelope-from gnats) Resent-Date: Wed, 9 Jan 2008 10:30:02 GMT Resent-Message-Id: <200801091030.m09AU2V7041312@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 717FA16A41A for ; Wed, 9 Jan 2008 10:26:36 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.10]) by mx1.freebsd.org (Postfix) with ESMTP id F2BC413C478 for ; Wed, 9 Jan 2008 10:26:35 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87]) by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id m09AQKNk054853 for ; Wed, 9 Jan 2008 11:26:21 +0100 (CET) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost. [127.0.0.1]) by kulesh.obluda.cz (8.14.2/8.14.2) with ESMTP id m09AQJi0049434 for ; Wed, 9 Jan 2008 11:26:19 +0100 (CET) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.14.2/8.14.1/Submit) id m09AQJhf049433; Wed, 9 Jan 2008 11:26:19 +0100 (CET) (envelope-from dan) Message-Id: <200801091026.m09AQJhf049433@kulesh.obluda.cz> Date: Wed, 9 Jan 2008 11:26:19 +0100 (CET) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/119483: vidcontrol miss latest VESA mode (off-by-one bug) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2008 10:30:02 -0000 >Number: 119483 >Category: bin >Synopsis: vidcontrol miss latest VESA mode (off-by-one bug) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 09 10:30:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 6.3-PRERELEASE i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Mon Jan 7 20:31:37 CET 2008 root@:/usr/obj/usr/src/sys/KULESH i386 src/usr.sbin/vidcontrol/vidcontrol.c,v 1.52.2.2 2006/10/04 06:09:11 >Description: vidcontrol -i mode miss the mode 0x1ff=M_VESA_MODE_MAX in listing due off-by-one bug The M_VESA_MODE_MAX is latest valid mode - not the first invalid >How-To-Repeat: use vidcontrol -i mode on hardware which has 0x1ff mode - it will not be listed >Fix: --- /usr/src/usr.sbin/vidcontrol/vidcontrol.c.ORIG 2008-01-09 11:20:05.000000000 +0100 +++ /usr/src/usr.sbin/vidcontrol/vidcontrol.c 2008-01-09 11:20:35.000000000 +0100 @@ -960,7 +960,7 @@ printf("---------------------------------------" "---------------------------------------\n"); - for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) { + for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) { _info.vi_mode = mode; if (ioctl(0, CONS_MODEINFO, &_info)) continue; >Release-Note: >Audit-Trail: >Unformatted: