From owner-svn-ports-head@FreeBSD.ORG Thu Nov 15 10:38:54 2012 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 719D78F2; Thu, 15 Nov 2012 10:38:54 +0000 (UTC) Date: Thu, 15 Nov 2012 10:38:54 +0000 From: Alexey Dokuchaev To: Florian Smeets Subject: Re: svn commit: r307446 - head/www/xpi-colorfultabs Message-ID: <20121115103854.GA66564@FreeBSD.org> References: <201211151016.qAFAGgQj064519@svn.freebsd.org> <20121115112221.ba4ce4e361a4fe5f627f0199@critical.ch> <50A4C343.7080501@smeets.im> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <50A4C343.7080501@smeets.im> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, Emanuel Haupt , svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2012 10:38:54 -0000 On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote: > On 11/15/2012 11:22, Emanuel Haupt wrote: > > These two files are probably not needed. > > Yeah, i know. I saw them but decided to just add them to the plist, > rather than hacking up the Makefile with something to use find on the > WRKSRC and delete them. > > If anybody sees this as a problem, i can hack the Makefile to delete > them prior to installation. Yes, it is a problem. It makes us (FreeBSD) look like careless fools not even able (or giving a shit about) to keep crap out of the packages we ship. These things add up, regardless of how non-functional they might be, to the bad impression of us. Please try to make ports nice and clean, remove the crap, it's very easy: post-extract: # Remove the crap @${FIND} ${WRKSRC} -type f -name ... -delete Slighly longer for directories. ./danfe