From owner-svn-src-head@FreeBSD.ORG  Wed Oct 22 09:48:44 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 98364644;
 Wed, 22 Oct 2014 09:48:44 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 5AFF43FD;
 Wed, 22 Oct 2014 09:48:44 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id AD366AC72;
 Wed, 22 Oct 2014 09:48:42 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 0431654FD; Wed, 22 Oct 2014 11:48:31 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Warner Losh <imp@bsdimp.com>
Subject: Re: svn commit: r273417 - head
References: <201410212029.s9LKThT2074337@svn.freebsd.org>
 <86d29k28wh.fsf@nine.des.no>
 <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com>
Date: Wed, 22 Oct 2014 11:48:30 +0200
In-Reply-To: <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> (Warner Losh's
 message of "Tue, 21 Oct 2014 19:49:33 -0600")
Message-ID: <86iojco2oh.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2014 09:48:44 -0000

Warner Losh <imp@bsdimp.com> writes:
> I=E2=80=99ll fix this. I think we need to have a MK_TESTS_SUPPORT that bu=
ilds
> the libatf stuff when yes, and omits it when no, since we don=E2=80=99t w=
ant
> the tests building when we=E2=80=99re building the 4.3 stage.

I agree, bundling everything under MK_TESTS does not make much sense.
Automake has the same bug ("make check" will both build the tests and
run them, and while you can rerun the tests without rebuilding them
("make recheck"), there is no way to build them without running them.

I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though.  The
test framework is probably useful on its own.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no