From owner-freebsd-bugs Mon Jan 15 0: 2:40 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id F29A537B400 for ; Mon, 15 Jan 2001 00:02:20 -0800 (PST) Received: (qmail 1775 invoked by uid 1000); 15 Jan 2001 08:00:57 -0000 Date: Mon, 15 Jan 2001 10:00:57 +0200 From: Peter Pentchev To: Josef Karthauser Cc: freebsd-bugs@FreeBSD.org Subject: Re: misc/24321: cdcontrol default still using old device name cd0c Message-ID: <20010115100057.A1294@ringworld.oblivion.bg> Mail-Followup-To: Josef Karthauser , freebsd-bugs@FreeBSD.org References: <200101141640.f0EGe2952128@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101141640.f0EGe2952128@freefall.freebsd.org>; from joe@tao.org.uk on Sun, Jan 14, 2001 at 08:40:02AM -0800 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sun, Jan 14, 2001 at 08:40:02AM -0800, Josef Karthauser wrote: > The following reply was made to PR misc/24321; it has been noted by GNATS. > > From: Josef Karthauser > To: davidx@viasoft.com.cn > Cc: freebsd-gnats-submit@FreeBSD.org > Subject: Re: misc/24321: cdcontrol default still using old device name cd0c > Date: Sun, 14 Jan 2001 16:35:53 +0000 > > On Sun, Jan 14, 2001 at 12:41:41AM -0800, davidx@viasoft.com.cn wrote: > > > cdcontrol default is still using old device name cd0c while FreeBSD 4.x > > is already using new ATAPI interface and default cdrom device name is > > already changed to /dev/acd0c, cdcontrol is simply not follow-up. > > cd0c isn't an old name, it's the name of the SCSI cdrom device. > I've just MFC'd a fix from -current which allows you to define the > default device to use in the CDROM environment variable. > > After cvsup'ing you should be able to add something like the following > to your startup scripts: > > export CDROM=acd0 Mmm.. am I missing something here? I thought cdcontrol(1) already checked four other environment variables - MUSIC_CD, CD_DRIVE, DISC and CDPLAY - and set the cdname variable appropriately before checking for -f? So the -f flag would override the environment default, and *both* the env vars and the -f flag would override the /dev/cd0c hardwired default? The checks are before the getopt() call, you have just added another one after the call.. is there a reason that those be separated? I personally have been setting MUSIC_CD in my profiles since forever, and it has worked perfectly well. And the manpage documented the old behavior too, near the top; true, it did not have an ENVIRONMENT section, but.. :) G'luck, Peter -- No language can express every thought unambiguously, least of all this one. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message