From owner-freebsd-stable@FreeBSD.ORG  Thu Oct  5 21:41:38 2006
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: freebsd-stable@freebsd.org
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F89416A412;
	Thu,  5 Oct 2006 21:41:38 +0000 (UTC)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6941543D45;
	Thu,  5 Oct 2006 21:41:37 +0000 (GMT)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from atlantis.dp.ua (localhost [127.0.0.1])
	by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id k95LfXmb016352; 
	Fri, 6 Oct 2006 00:41:33 +0300 (EEST)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from localhost (dmitry@localhost)
	by atlantis.dp.ua (8.13.1/8.13.1/Submit) with ESMTP id k95LfWut016348; 
	Fri, 6 Oct 2006 00:41:33 +0300 (EEST)
	(envelope-from dmitry@atlantis.dp.ua)
Date: Fri, 6 Oct 2006 00:41:32 +0300 (EEST)
From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To: Eugene Grosbein <eugen@kuzbass.ru>
In-Reply-To: <20061005211121.GA95111@svzserv.kemerovo.su>
Message-ID: <20061006002847.F36667@atlantis.atlantis.dp.ua>
References: <451F6E8E.8020301@freebsd.org> <4523916C.1080905@crc.u-strasbg.fr>
	<20061004163622.GA35298@xor.obsecurity.org>
	<20061004173637.GA66349@svzserv.kemerovo.su>
	<20061005102923.N84384@fledge.watson.org>
	<20061005115140.GA47746@svzserv.kemerovo.su>
	<20061005130829.A46123@fledge.watson.org>
	<20061005144852.GA60575@svzserv.kemerovo.su>
	<20061005164821.GA71411@svzserv.kemerovo.su>
	<20061005235729.H36667@atlantis.atlantis.dp.ua>
	<20061005211121.GA95111@svzserv.kemerovo.su>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Robert Watson <rwatson@freebsd.org>,
	FreeBSD Stable <freebsd-stable@freebsd.org>, bug-followup@freebsd.org
Subject: Re: kern/103841: [fdc] fdc(4) does not work (regression)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2006 21:41:38 -0000


Hello!

On Fri, 6 Oct 2006, Eugene Grosbein wrote:
>>>> fdc0: <floppy drive controller> port 0x3f0-0x3f5,0x3f0 irq 6 drq 2 on
>>>> acpi0
>> ----------------------------------------^^^^^^^^^^^^^^^^^
>>  Bad (no 0x3f7, 0x3f0 gets listed twice).
>
> Recent revisions of fdc(4) do not use control register at port 0x3f7.

  Are you sure? I see the following in /sys/dev/fdc/fdc.c (CURRENT version):

#define   FDCTL   7       /* Control Register (W) */

static void
fdctl_wr(struct fdc_data *fdc, u_int8_t v)
{
         fdregwr(fdc, FDCTL, v);
}

Well, in CURRENT it _may not_ be used if you've got the "Enhanced"
floppy controller:

         if (fdc->fdct == FDC_ENHANCED)
                 fddsr_wr(fdc, fd->ft->trans);
         else
                 fdctl_wr(fdc, fd->ft->trans);

while in RELENG_6 it's always

 	fdctl_wr(fdc, fd->ft->trans);

That's why version from CURRENT works for you despite the absence of 0x3f7
resource. But it's incorrect to say that "Recent revisions of fdc(4) do not 
use control register at port 0x3f7" - actually they do for non-FDC_ENHANCED 
case.

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE