From owner-svn-src-head@FreeBSD.ORG Sun Sep 27 21:11:57 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E6B610656A8 for ; Sun, 27 Sep 2009 21:11:57 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.freebsd.org (Postfix) with ESMTP id E20AB8FC2E for ; Sun, 27 Sep 2009 21:11:56 +0000 (UTC) Received: from vampire.homelinux.org (dslb-088-066-054-182.pools.arcor-ip.net [88.66.54.182]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0LroMs-1MNbSH3NB0-013zjU; Sun, 27 Sep 2009 23:11:55 +0200 Received: (qmail 68666 invoked from network); 27 Sep 2009 21:11:55 -0000 Received: from kvm.laiers.local (HELO kvm.localnet) (192.168.4.200) by mx.laiers.local with SMTP; 27 Sep 2009 21:11:55 -0000 From: Max Laier Organization: FreeBSD To: "Simon L. Nielsen" Date: Sun, 27 Sep 2009 23:11:56 +0200 User-Agent: KMail/1.12.1 (Linux/2.6.30-ARCH; KDE/4.3.1; x86_64; ; ) References: <200909251824.n8PIOLte036513@svn.freebsd.org> <20090927070220.GA18022@FreeBSD.org> <20090927145509.GG1495@arthur.nitro.dk> In-Reply-To: <20090927145509.GG1495@arthur.nitro.dk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200909272311.56602.max@love2party.net> X-Provags-ID: V01U2FsdGVkX19uJW9F0uE9VTBseoXF9Z4RItABbFcPM/q8c7E CBMrWKYm7EGyEiUH4/vNn/mZK8rroWFiD4tAz1lMwR3OJRof03 vjzVVY8hTs= Cc: Alexey Dokuchaev , src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, Thomas Backman , svn-src-head@freebsd.org, Dag-Erling Sm??rgrav Subject: Re: svn commit: r197498 - head/cddl/contrib/opensolaris/cmd/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2009 21:11:57 -0000 On Sunday 27 September 2009 16:55:10 Simon L. Nielsen wrote: > On 2009.09.27 07:02:21 +0000, Alexey Dokuchaev wrote: > > On Sat, Sep 26, 2009 at 10:51:58PM +0200, Dag-Erling Sm??rgrav wrote: > > > Pawel Jakub Dawidek writes: > > > > I didn't, thanks. Unfortunately svn doesn't even allow forced > > > > commits, which is a paintful regression compared to cvs. > > > > > > Subversion does allow editing a log message after the fact, but our > > > commit scripts prohibit it. This should IMHO be allowed, and cause a > > > new email to be sent out to note the change. > > > > I recall that one of the reasons behind prohibition was to avoid issues > > with CVS exporter. > > I doubt the CVS exporter would have a problem, though I'm not 100% > sure. I think the problem is more that svnsync does not pick up the > change, but des knows more about that than I do. > > PS. I don't personally have a problem allowing people to edit commit > messages, as long as it's "visible" and we knows what the side-effects > are. svn ps fbsd:forced r197498 head/cddl/contrib/opensolaris/cmd/zfs/zfs.8 svn ci -m "Revised commit message" There you go. Forced commit with no problem. Plus we can also record the revision that the forced commit message belongs to. Disclaimer: Don't try this on the main repo before the SVN-meisters have had a look and approve. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News