From owner-freebsd-fs@FreeBSD.ORG Sun Sep 13 20:24:02 2009 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A598A106568B for ; Sun, 13 Sep 2009 20:24:02 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 3EFDB8FC0C for ; Sun, 13 Sep 2009 20:24:01 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 8275945CA6; Sun, 13 Sep 2009 22:24:00 +0200 (CEST) Received: from localhost (chello087206049004.chello.pl [87.206.49.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 8002945C9C for ; Sun, 13 Sep 2009 22:23:55 +0200 (CEST) Date: Sun, 13 Sep 2009 22:23:50 +0200 From: Pawel Jakub Dawidek To: freebsd-fs@FreeBSD.org Message-ID: <20090913202350.GE2091@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xJK8B5Wah2CMJs8h" Content-Disposition: inline User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Subject: Review request for NFS readdirplus change. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2009 20:24:02 -0000 --xJK8B5Wah2CMJs8h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi. I'm looking for a review of the following patch: http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch The main purpose of this patch is to support stuff like ZFS, where using VFS_VGET() might be tricky on .zfs/ directory and friends. When VFS_VGET() is not supported be the underlying file system, we switch to VOP_LOOKUP(). Note that OpenSolaris NFS server implementation always uses lookup for readdirplus. I also modified the code to use shared-locking, there is no need to exclusively lock the vnodes. The patch removes an assert which doesn't hold for ZFS when we go into =2Ezfs/snapshot// directory, which is separate mount point, but we don't want to export it separately, so we still return it on lookup. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --xJK8B5Wah2CMJs8h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKrVTWForvXbEpPzQRApcpAKCjYe9Fx6bqf04Ox7DhNUEfnwgKyACfQHe+ EccHmQhVFlUAxYn7OY3KaNI= =IrPL -----END PGP SIGNATURE----- --xJK8B5Wah2CMJs8h--