From owner-freebsd-arch@FreeBSD.ORG  Fri Jan 13 17:17:59 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.ORG
Received: by hub.freebsd.org (Postfix, from userid 1035)
	id 7A13D16A420; Fri, 13 Jan 2006 17:17:59 +0000 (GMT)
Date: Fri, 13 Jan 2006 17:17:59 +0000
From: Xin LI <delphij@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20060113171759.GA1255@hub.freebsd.org>
References: <20060113170552.GF83922@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060113170552.GF83922@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: arch@FreeBSD.org, re@FreeBSD.org
Subject: Re: review: patch to restore VLAN kernel API in RELENG_6
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2006 17:17:59 -0000

Hi, Gleb,

On Fri, Jan 13, 2006 at 08:05:52PM +0300, Gleb Smirnoff wrote:

> Index: sys/dev/bge/if_bge.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
> retrieving revision 1.91.2.7
> diff -u -r1.91.2.7 if_bge.c
> --- sys/dev/bge/if_bge.c	13 Jan 2006 11:51:08 -0000	1.91.2.7
> +++ sys/dev/bge/if_bge.c	13 Jan 2006 17:04:31 -0000
> @@ -2862,7 +2862,7 @@
>  		 * attach that information to the packet.
>  		 */
>  		if (have_tag) {
> -			VLAN_INPUT_TAG(ifp, m, vlan_tag);
> +			VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);

What if "VLAN_INPUT_TAG_2" or something with numerical name?

Just my $0.02, though :-)

Cheers,