From owner-freebsd-current@FreeBSD.ORG Fri Jun 24 18:35:40 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B908106564A for ; Fri, 24 Jun 2011 18:35:40 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id D002C8FC0A for ; Fri, 24 Jun 2011 18:35:39 +0000 (UTC) Received: by pwi7 with SMTP id 7so687410pwi.13 for ; Fri, 24 Jun 2011 11:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FfpoCIwDzJZTZbDtadFiubqJHEW72YycECHiNLTAZrQ=; b=TJmbPrUnDhUlQxv1sTclZT7+IjhimUKffkcZiSN0k7kwYF9VfnRlmeWWi8ft8gzWpb CxNY6sB9085WjXqxoA2A11adOSTOJlWQvImKq5C/oiKHvY4xo/9Os74VjCcbEgmTjJ5n GTf3jVXOWyK0ZX/qUfP8EvIl8QmKP4kUN9jCg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=jk3nUGZIZ3CRaZ82RmCRCIb5w57vVVeZL0xLEZHltIpr4DLLUXHEj4ZaqaZR6vsdVe 9fFYnD2rcECQ4FgSqCjjCeCVJO9XF0iz2duWJ/+eXutLa2dDT+LouRiA2k9dCjv3v1Ca kox9kihMyrxDK5tK02veNluPvmGK7sj7xtDoo= Received: by 10.68.44.164 with SMTP id f4mr1784208pbm.392.1308940539125; Fri, 24 Jun 2011 11:35:39 -0700 (PDT) Received: from sidhe.local ([75.101.87.90]) by mx.google.com with ESMTPS id x1sm2237768pbb.18.2011.06.24.11.35.36 (version=SSLv3 cipher=OTHER); Fri, 24 Jun 2011 11:35:37 -0700 (PDT) Message-ID: <4E04D8F6.1090206@gmail.com> Date: Fri, 24 Jun 2011 11:35:34 -0700 From: Matt User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110502 Thunderbird/3.1.10 MIME-Version: 1.0 To: Jung-uk Kim References: <4E04C5FA.90905@gmail.com> <201106241352.14262.jkim@FreeBSD.org> In-Reply-To: <201106241352.14262.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org Subject: Re: virtualbox-ose 4.0.8 fails X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2011 18:35:40 -0000 On 06/24/11 10:52, Jung-uk Kim wrote: > On Friday 24 June 2011 01:14 pm, Matt wrote: >> It fails a couple ways actually, first on an isDVD in a disk system >> request...commenting out the inq_(something, not in front of >> machine with recent svn) parts of that code yields virtualbox >> compiling, but failing during kmod compile due to the recent change >> (without revision bump) from cpumask_t to cpuset_t. >> >> It seems like recent CAM changes and CPU change are going to >> require some changes to virtualbox in HostHardwareFreeBSD.c and >> mp-r0drv.c at least. Even though OS revision was not bumped, >> perhaps Makefile can switch on presence of cpuset userland utility? >> >> Luckily I only csup'd a machine I don't really need Vbox on, so I'm >> holding back all other machines until Vbox maintainers sort out the >> issue. > You should be able to build the kmod with this patch. > > http://people.freebsd.org/~jkim/patch-src-VBox-Runtime-r0drv-freebsd-mp-r0drv-freebsd.c > > Just drop this patch in ports/emulators/virtualbox-ose-kmod/files and > rebuild. > > Please note the revision wasn't set right for the obvious reason, > though. Do we really need revision bump, BTW? "Current" means "no > seat belt" anyway. ;-) > > Cheers, > > Jung-uk Kim > Thanks for the patch. I had read a comment somewhere complaining about detecting cpuset_t or cpumask_t regarding osrevision. Not really an issue, because it can be tested for without a bump. Who needs seatbelts anyway... :). CURRENT & a cold beer is good enough for my home systems. Certainly prevents boredom anyway. The Virtualbox error (not kmod error) looked like it was using an undefined struct to determine drive types, which I assume has been removed. If you &> the make output into a file and search for isDVD, you'll find that particular error, if still present. I just commented out the parts of the struct we don't have anymore, and it did compile...definitely could be dangerous, I haven't actually launched virtualbox with that "fix"...it could make for subtle or major problems. Your mileage & seatbelt may vary :) Matt Matt