From owner-svn-src-all@freebsd.org Tue Apr 25 19:33:23 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62F5DD50873; Tue, 25 Apr 2017 19:33:23 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x230.google.com (mail-oi0-x230.google.com [IPv6:2607:f8b0:4003:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2634B1174; Tue, 25 Apr 2017 19:33:23 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x230.google.com with SMTP id w12so72348304oiw.3; Tue, 25 Apr 2017 12:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e8JEklOHsaIcRfy9NMKa8JL7UaQahwucGF+VSmo9M0s=; b=DF+3/DkGyzaECe7ScqwBrqrtRqduCtmtZqpyFjl05Rq+JxPX0fw/45wjQTPv3rU2vq cH0not8JDHOmkNbbqIklfg74l1L1OHSaSwQMSP9eguENgPzQFuDQlnv3Gp+g6Nb4KUHP BdWu+dcDXvsmNITqLgF5dYoWOwMtAvt/0kFs0h+EUGGtQTQCwggFv/yOyKbnBmdf9XDN MX4QEth2ZUvOatt/6LHTYXnCJGywtawM0EGoYEn869W+h+n7KuR5bG/H0ok+0rkFz/6q L/FRSfplvYWlz/qIh+A2UJbyTZpwvRhSRFILQOEKuyypOB2XCIpXlSu5AwkvgMVwBtVK 6x6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e8JEklOHsaIcRfy9NMKa8JL7UaQahwucGF+VSmo9M0s=; b=LiOHe9KtOsPN9w7BqKMyUSM2TENa+eojg7430LxBpS0KL33LTeS3kd2Sl4oyxik0rq 1UX7EWP1QgASyJEsWcbYnGzaDzKcNNN2aeYvL6D909CILUcGevQ93CtSz1XSpBRES9PU tVs2wqvqW0DJzl56wLYCF59LowUASV3iKqyTEJL2i/lev6T9e4q9Xu8HCyL18qZHuMrv /30wYW9WMmy5O8WDlR1jdV1ozNtrhOk8oWkQ082VdhqQx+PJUVe4PrEiD6Dz1U+FLKmY +d77dYEwxGAEnhFP58MkwpccXVQCZTd3wQ2AWkchAs2P2L2f1JpcpGB47oCiIvMM2sAp 671A== X-Gm-Message-State: AN3rC/6MAZUXpETaV4QJFtE4GpoVChu2JXYXYnLJKpImYdBvgDmG7p5y I2GpZxKLFBeQqo0jtiWkfIkBVcREEw== X-Received: by 10.157.17.82 with SMTP id p18mr22362775otp.222.1493148802288; Tue, 25 Apr 2017 12:33:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.50.133 with HTTP; Tue, 25 Apr 2017 12:33:21 -0700 (PDT) In-Reply-To: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> References: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> From: Benjamin Kaduk Date: Tue, 25 Apr 2017 14:33:21 -0500 Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump To: rgrimes@freebsd.org Cc: Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 19:33:23 -0000 On Tue, Apr 25, 2017 at 2:07 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > > > On the contrary, a git SHA1 seems like an eminently stable and unique > > search parameter! > > I agree that a commit log should inline some summary of the change as > well > > as provide a > > link to the external source, but I am not worried that a future reader > will > > be unable to find > > the referenced commit. > > There is no administrative policy in place that says github users shall > maintain there history. > > That is correct. Nor should there be! (However, even if they change their history, the direct link to a commit will still work, due to the way the github implementation works -- you have to delete and recreate a repository in order to fully expunge a commit.) I don't expect the previous parenthetical to provide any persuasive value, of course, as you have to know where to look before it's useful. But, right now there are some 300-odd forks of tcpdump on github, no doubt including Gleb. If the-tcpdump-group goes away, there's a lot of backups, not just in github forks but also the local clones of people using github. Do you really think that the collapse of such a prominent project would leave an unarchived void? I don't understand what scenario you're trying to protect against, basically. > I had too many indirections to find this change on github: > commitlog -> google -> wrong article that references this sha1 -> actual > commit > > I re-iterate lets NOT start to use git hashes in our commit messages. > I'm sorry, but I must continue to oppose this sentiment. I would prefer a full (github or otherwise) URL including the commit hash to just a bare commit hash, but find either acceptable and adequate for the purpose. (FWIW, the correct commit was the top google hit for me.) I hope we are in agreement that commit messages ought to still include some description of what change is being brought in, in addition to the hash/link, though. -Ben