From owner-freebsd-current@FreeBSD.ORG Thu Jul 5 14:45:13 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B9F1716A421 for ; Thu, 5 Jul 2007 14:45:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 6266F13C4BB for ; Thu, 5 Jul 2007 14:45:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [89.162.146.170] (helo=skuns.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1I6SZp-000C1F-Cj for current@freebsd.org; Thu, 05 Jul 2007 17:45:10 +0300 Received: from deviant.kiev.zoral.com.ua (root@[10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l65EiiGE034404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Jul 2007 17:44:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l65EiiDl023211; Thu, 5 Jul 2007 17:44:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l65Eiipa023210; Thu, 5 Jul 2007 17:44:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2007 17:44:44 +0300 From: Kostik Belousov To: Danny Braniss Message-ID: <20070705144443.GV2200@deviant.kiev.zoral.com.ua> References: <20070703180141.GJ2200@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OFtM20PmL5gDcvsL" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.90.2, clamav-milter version 0.90.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on skuns.kiev.zoral.com.ua X-Scanner-Signature: b88a486dba0f71889b871e8b63a4ea3b X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1189 [July 05 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: current@freebsd.org Subject: Re: HEADS UP: destroy_dev_sched() KPI in the tree X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2007 14:45:13 -0000 --OFtM20PmL5gDcvsL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 05, 2007 at 05:18:43PM +0300, Danny Braniss wrote: >=20 > > Today, I got re@ permission and committed the destroy_dev_sched() KPI > > into the tree. As suggested by Nate Lawson, destroy_dev() tries to > > auto-detect "devdrn" deadlock condition and transforms destroy_dev() > > from d_close() csw method into destroy_dev_sched(). I together with > > Peter Holm tried to test the change as thoroughly as possible. > >=20 > > The obvious problematic area are the races between device driver > > module unload and destroy_dev_sched(). At least smb(4) definitely > > has that race that shall be worked around by draining events with > > drain_dev_clone_events() and destroy_dev_drain(&cdevsw); see snp(4) > > change for example. > >=20 > > Please, report issues caused by the patch to the list with me Cc:ed. > > Change of autodetection of deadlock in destroy_dev() was made in separa= te > > commit for ease of reverting. >=20 > and today I got a chance to check it, and it works for me (iscsi_initiato= r). Today, I reverted the part of commit that tried to transform destroy_dev() from d_close() into destroy_dev_sched(). See kern_conf.c, rev. 1.208. You shall call destroy_dev_sched() explicitely. --OFtM20PmL5gDcvsL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGjQPbC3+MBN1Mb4gRAm/XAJsHjAjLcEJoqbw1ugSJDHblp5sWEwCffAaP YQsQd2TZur4rGleReWOaMfw= =ihR6 -----END PGP SIGNATURE----- --OFtM20PmL5gDcvsL--