From owner-freebsd-office@FreeBSD.ORG Tue May 26 17:07:48 2015 Return-Path: Delivered-To: office@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B46CD7A4 for ; Tue, 26 May 2015 17:07:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F030799 for ; Tue, 26 May 2015 17:07:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4QH7mTq007619 for ; Tue, 26 May 2015 17:07:48 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: [Bug 200236] [maintainer][patch] games/wesnoth: fix for some FreeBSD 10.1 builds Date: Tue, 26 May 2015 17:07:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: marino@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 17:07:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200236 --- Comment #25 from John Marino --- "Being practical, OPSYS/OSVERSION checks are _always_ more complex and less correct than compiler check." It's equally correct. It also doesn't require changing USES so I don't get its considered more complex. The outliers are FreeBSD 8 and 9. In reality there should be a standard macro / USES for this, it's a fairly common issue. "It really is a boost issue, see comment #1. You won't catch this with poudriere. (his fix is not correct. This is not problem in wesnoth but boost - it build unusable library in presence of libiconv. Boost should be fixed instead.)" What changed? Boost has been the same forever. Wesnoth just reverted to what it was. the bsd_iconv thing is FreeBSD 11 only isn't it? Are you saying when you build it in ports, there is a good chance that libiconv is already installed for another reason and boost builds wrong outside of poudriere? I think that's what you must mean. I would think that would also be limited to a -CURRENT. -- You are receiving this mail because: You are on the CC list for the bug.