From owner-cvs-all@FreeBSD.ORG  Tue Dec  6 03:20:07 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D9B7B16A41F;
	Tue,  6 Dec 2005 03:20:07 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 79A3643D58;
	Tue,  6 Dec 2005 03:20:07 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jB63K7Kf074967;
	Tue, 6 Dec 2005 03:20:07 GMT
	(envelope-from csjp@freefall.freebsd.org)
Received: (from csjp@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jB63K7HW074966;
	Tue, 6 Dec 2005 03:20:07 GMT (envelope-from csjp)
Date: Tue, 6 Dec 2005 03:20:07 +0000
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Jung-uk Kim <jkim@FreeBSD.org>
Message-ID: <20051206032007.GB70151@freefall.freebsd.org>
References: <200512060258.jB62wCnk084452@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200512060258.jB62wCnk084452@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/amd64/amd64 bpf_jit_machdep.c
	bpf_jit_machdep.h src/sys/conf files files.amd64 files.i386
	options.amd64 options.i386 src/sys/i386/i386
	bpf_jit_machdep.c bpf_jit_machdep.h src/sys/net bpf.c
	bpf_jitter.c bpf_jitter.h bpfdesc.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2005 03:20:08 -0000

On Tue, Dec 06, 2005 at 02:58:12AM +0000, Jung-uk Kim wrote:
>   
>   Revision  Changes    Path
[..]
>   1.162     +54 -3     src/sys/net/bpf.c
>   1.1       +85 -0     src/sys/net/bpf_jitter.c (new)
>   1.1       +80 -0     src/sys/net/bpf_jitter.h (new)
[..]

                BPFD_LOCK(d);
                if (wfilter)
                        d->bd_wfilter = fcode;
                else {
                        d->bd_rfilter = fcode;
#if BPF_JITTER
                        d->bd_bfilter = bpf_jitter(fcode, flen);
#endif

You are calling bpf_jitter() with a mutex held, and it looks like
bpf_jitter() will call malloc with M_WAITOK. Are you sure you want
to do this?


-- 
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team