From owner-cvs-src@FreeBSD.ORG Mon Jul 9 20:13:42 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D3A9F16A421 for ; Mon, 9 Jul 2007 20:13:42 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 9100713C4CA for ; Mon, 9 Jul 2007 20:13:42 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so235349anc for ; Mon, 09 Jul 2007 13:13:41 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VUiyHspgd3XMfemkM3TgDllt2Z4y4DBXMjnE59XHwBpJvPf9wph1XPXAeHkAciXI8ERnsfw6MlKqzay2/ZgMvF7/BlUNuXTigxz6D5LAdsgVplxQITA1uh9fHeUQt293hUZaDd1rqYEI5CSe0164LAVQlsDzwncAMCRl8AlgiQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=AC0rpcSGIGw4M6Gh/NGurKuZ9CBV7NGiECTaGiRY4nFkUV+8MbK89gYzbLPgGD5cy10hcOGCjuVncQ2x9hb3eRjc9tlyLrB1i9GukcfBT2Dsq3GYbLpky/x8EKp61yxe0/mIclWjgqUUN59n7WH2J2RweWlfzYXiTBuCO+MuudM= Received: by 10.100.138.2 with SMTP id l2mr1790622and.1184010407296; Mon, 09 Jul 2007 12:46:47 -0700 (PDT) Received: by 10.100.190.17 with HTTP; Mon, 9 Jul 2007 12:46:47 -0700 (PDT) Message-ID: Date: Mon, 9 Jul 2007 15:46:47 -0400 From: "Constantine A. Murenin" To: "Warner Losh" In-Reply-To: <200707091658.l69Gw8MG080618@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200707091658.l69Gw8MG080618@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb if_rue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2007 20:13:42 -0000 On 09/07/07, Warner Losh wrote: > imp 2007-07-09 16:58:08 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb if_rue.c > Log: > When all the other drivers were converted to scheduling a taskqueue to > do the heavy lifting of the 'mii_tick' function, rue was left behind. > Implement this in a naive way. Reports from the field show this makes > the driver functional with some locking issues, as opposed to an > instant panic. Those will be addressed in a later version of the > driver. > > Approved by: re@ (bmah) > > Revision Changes Path > 1.40 +18 -0 src/sys/dev/usb/if_rue.c I think you forgot to commit a change to src/sys/dev/usb/if_ruereg.h: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_detach': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:710: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_tick': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:931: error: 'struct rue_softc' has no member named 'rue_tick_task' Cheers, Constantine.