From nobody Thu Oct 31 19:52:56 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfZRD1tBPz5cHFT; Thu, 31 Oct 2024 19:52:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfZRD1LTXz4Pyg; Thu, 31 Oct 2024 19:52:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730404376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J0vE1OJClCZjxb2TDR+wAK0yWy6zH//DJ354kmudg6Y=; b=vFmGRZBWvSkg6mbA0JgAq7gpYRZZ17xS4zYKS7YY2PqB+PYdvgz9XAKJ4lJkeEJkI+Fu1o EIkQBBLhXwAREXobvF6wEf7uh/4JTaRkfPOK65elt6trAp31awaklC4WxQ/+BMTyK7kjwr hIubmF1bDjCFlaTYQHkhlnnzhQVQQg5veXxzdzlw41Is1+a0rX/yWWMpBh0Nvsg7RQ87Wi vFAVTyz8l7dpCBRB8+upS3oRNHNh0o9JxnLrkMsJPUx1l2w7vliX6Z0t8Y+2fmm/A3BfvR oHcBdxGl+wSzAZy5CXc1citXZKfinHwXShRWtU8Cfx1ghg6qolcgcgdO7Ex5/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730404376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J0vE1OJClCZjxb2TDR+wAK0yWy6zH//DJ354kmudg6Y=; b=iTEPaTkHqkJx50CIP8FtGSHUrp7WOtLgqxBrd/T4kRnHa+3hTnoeYeOEaO2L9/udDj/9Ed ZzFLnXrPKrIr5NiMgEcePjGm5HjePvjGtBXmr+Lie88/xkyMCtJSPLkq7nhj0CqP87NdxP DLNUAsHQSZnvEMjzJvrFCE8PvT/bgAJ1aiq1brg2udIhz5E8YskfblNFNu7Q9N+V51ZCuw SXqADxvNfnl/C/lJX47CofJFS/kBX0SZIA33IWE2Vg+ZnZ78m5X2DbsO/oX2We5VlsHP00 lTsyWLlnZ2EZzJXQAv06n/doq1Czz0X3vY4fvlT/yGjND3KOtuWCfMGnQGCNEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730404376; a=rsa-sha256; cv=none; b=qMm5bMlViE6HbodAgrG5oMYtATuPoF1x5GZ5kStqRmix2NOyd6S2ReAw0iFY6ys/8aSV4z +D2uWjeNhLzSlLDbOdMmLFBcQ1ow5em7ciR/SBhT+R3BU265eaq8xSi7E1BmXOM+G8Xt+g 1e8HPRuG/AY5L4aq0UAZTIUm5XOm2bEOSrdyCypRWn/TeFiuHBc5HYF0kjzdtmqMyMMELG 8v00qs9tFR4eeOM7bcxiWz4l3LeU8tcY60sP2UOjpLFYEgfe2MmHAMJxYEv32J8PHukIso 3xLPK/KEpNMK6bNlGJ7F1ZCZCm8iadm4vLsUMX4Amzci25Q/CDHy0mD+REqLMQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XfZRD0xy1zqNT; Thu, 31 Oct 2024 19:52:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49VJqudX005917; Thu, 31 Oct 2024 19:52:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49VJquaA005914; Thu, 31 Oct 2024 19:52:56 GMT (envelope-from git) Date: Thu, 31 Oct 2024 19:52:56 GMT Message-Id: <202410311952.49VJquaA005914@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 1cddce89ce30 - main - fixup_pci: Remove unused attach DEVMETHOD List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1cddce89ce30570d554120af864d23c554cd5d18 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=1cddce89ce30570d554120af864d23c554cd5d18 commit 1cddce89ce30570d554120af864d23c554cd5d18 Author: John Baldwin AuthorDate: 2024-10-31 19:49:05 +0000 Commit: John Baldwin CommitDate: 2024-10-31 19:49:05 +0000 fixup_pci: Remove unused attach DEVMETHOD The probe routine always fails, so the attach routine is unused. However, this weird driver is really a quirk system for PCI and should be turned into PCI quirks instead. The Natoma quirk is also broken as it should be doing a runtime check either on mp_ncpus (or more likely to see if it is using APIC) instead of #ifdef. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47219 --- sys/dev/pci/fixup_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/pci/fixup_pci.c b/sys/dev/pci/fixup_pci.c index 4bccda90a040..cad175f301a3 100644 --- a/sys/dev/pci/fixup_pci.c +++ b/sys/dev/pci/fixup_pci.c @@ -55,7 +55,6 @@ static void fixc1_nforce2(device_t dev); static device_method_t fixup_pci_methods[] = { /* Device interface */ DEVMETHOD(device_probe, fixup_pci_probe), - DEVMETHOD(device_attach, bus_generic_attach), { 0, 0 } };