Date: Mon, 10 Oct 2022 14:57:08 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 266942] bsd.port.mk: Use .MAKE.UID instead of calling id(1) Message-ID: <bug-266942-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266942 Bug ID: 266942 Summary: bsd.port.mk: Use .MAKE.UID instead of calling id(1) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: naddy@FreeBSD.org CC: ports-bugs@FreeBSD.org Created attachment 237190 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D237190&action= =3Dedit bsd.port.mk.patch Assigning the output of a shell command to a make variable is expensive sin= ce the command is spawned every time the makefile is parsed. In bsd.port.mk, we can save an invocation of id(1) by using the built-in .MAKE.UID variable instead. Since older versions of bmake (12.x) don't have .MAKE.UID yet, we need to check with defined() first. See the attached pat= ch. That said, this change does not result in any measurable speedup for "make index". --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-266942-7788>