From owner-freebsd-hackers@FreeBSD.ORG  Tue Apr 18 19:30:27 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ECDD516A405
	for <freebsd-hackers@freebsd.org>; Tue, 18 Apr 2006 19:30:27 +0000 (UTC)
	(envelope-from peterjeremy@optushome.com.au)
Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au
	[211.29.132.197])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6C6AA43D53
	for <freebsd-hackers@freebsd.org>; Tue, 18 Apr 2006 19:30:26 +0000 (GMT)
	(envelope-from peterjeremy@optushome.com.au)
Received: from turion.vk2pj.dyndns.org
	(c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236])
	by mail16.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id
	k3IJUJ1s013024
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Wed, 19 Apr 2006 05:30:19 +1000
Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1])
	by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k3IJUJc1003063;
	Wed, 19 Apr 2006 05:30:19 +1000 (EST)
	(envelope-from peter@turion.vk2pj.dyndns.org)
Received: (from peter@localhost)
	by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k3IJUIbx003062;
	Wed, 19 Apr 2006 05:30:18 +1000 (EST) (envelope-from peter)
Date: Wed, 19 Apr 2006 05:30:18 +1000
From: Peter Jeremy <peterjeremy@optushome.com.au>
To: cokane@cokane.org
Message-ID: <20060418193018.GB694@turion.vk2pj.dyndns.org>
References: <444515C8.3030406@centtech.com>
	<20060418165709.GA17705@central.0xfce3.net>
	<44452532.40703@centtech.com>
	<20060418.114933.69380798.imp@bsdimp.com>
	<346a80220604181102v3597a1edp3e05fa663b87e15c@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <346a80220604181102v3597a1edp3e05fa663b87e15c@mail.gmail.com>
X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc
User-Agent: Mutt/1.5.11
Cc: freebsd-hackers@freebsd.org
Subject: Re: [PATCH] Fancy rc startup style RFC
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Apr 2006 19:30:28 -0000

On Tue, 2006-Apr-18 14:02:07 -0400, Coleman Kane wrote:
A few comments on the shellscript:

>+			rcargsize=`echo $rc_arg`
>+			rcargsize=${#rcargsize}

Try			rcargsize=$((${#rc_arg} + 1))

>-				    return 1
>+				    (echo_fancy "FAILED" `expr 10 + $rcargsize - 1`) && return 1

Try				    echo_fancy "FAILED" $((10 + $rcargsize - 1)) && return 1

>+echo_fancy () {
...
>+	namesize=`echo -n $name`
>+	namesize=${#namesize}
or	namesize=${#name}

>+	padding=""
>+	paddingsize=$(($columns - 15 - $2 - $namesize))
>+	until [ 0 = ${paddingsize} ]; do
>+		padding=" $padding"
>+		paddingsize=$(($paddingsize - 1))
>+	done

This particular block of code appears unnecessary (since $padding is unused).

>+			paddingsize=$((60 - $namesize - $rc_argsize))
>+			until [ 0 = ${paddingsize} ]; do
>+		  		padding=" $padding"
>+		  		paddingsize=$(($paddingsize - 1))
>+			done

For safety, the conditions should probably be [ 0 -ge ${paddingsize} ]
I don't see any alternative to the until loop.  If efficiency turns out
to be a real issue then you could try doing the expansion in multiple
goes.  Eg:

			until [ 8 -gt ${paddingsize} ]; do
		  		padding="        $padding"
		  		paddingsize=$(($paddingsize - 8))
			done
			until [ 0 -ge ${paddingsize} ]; do
		  		padding=" $padding"
		  		paddingsize=$(($paddingsize - 1))
			done

-- 
Peter Jeremy