From owner-svn-src-head@FreeBSD.ORG  Sat Nov 24 14:51:50 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id CD3E14C7
 for <svn-src-head@freebsd.org>; Sat, 24 Nov 2012 14:51:50 +0000 (UTC)
 (envelope-from mailer-daemon@vniz.net)
Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com
 [209.85.217.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 2BD528FC08
 for <svn-src-head@freebsd.org>; Sat, 24 Nov 2012 14:51:49 +0000 (UTC)
Received: by mail-lb0-f182.google.com with SMTP id go10so6843141lbb.13
 for <svn-src-head@freebsd.org>; Sat, 24 Nov 2012 06:51:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:disposition-notification-to:date:from:user-agent
 :mime-version:to:cc:subject:references:in-reply-to:openpgp
 :content-type:content-transfer-encoding:x-gm-message-state;
 bh=zYCLWZEuHFgxH1EcxyUBKDEv4KC87eP8otCgxrSebAM=;
 b=XeTUvhgah0RzSOsN0He7LEhALBD/XZbPDsbcDeEY87fU0R659Ng+sK7GRYVkowrCkb
 c0jK2QYbizmrmR3kcdmaQTy2UqzyrTUc40Iw0qaybTKZnW9IZyq2UWxQv2r3RMTmCsCk
 KyvVbX8Y8ftXPEAk8grms6i9OdusmmCiWq2dzBG1UyzczRv4YuKEQM4+0Px+Z5DpYco0
 Ypk4HbGdbqvfgP1AMhVDpuW9QI0iQau6V14QhMGqdh4hrfTMF+HP/XaKtf8vXWznGQC2
 g8d1FbLZZROpePMut8aZAxNc1DFdDEcKX8x9LspjXaWk0w2lN4pak62BSMfoOQgk8n6k
 NRuw==
Received: by 10.112.25.168 with SMTP id d8mr2552300lbg.62.1353768708624;
 Sat, 24 Nov 2012 06:51:48 -0800 (PST)
Received: from [192.168.1.2] ([89.169.163.3])
 by mx.google.com with ESMTPS id p9sm3634207lbc.3.2012.11.24.06.51.47
 (version=SSLv3 cipher=OTHER); Sat, 24 Nov 2012 06:51:47 -0800 (PST)
Message-ID: <50B0DF04.5060001@freebsd.org>
Date: Sat, 24 Nov 2012 18:51:48 +0400
From: Andrey Chernov <ache@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Dimitry Andric <dim@FreeBSD.org>
Subject: Re: svn commit: r243474 - head/usr.bin/cut
References: <201211240415.qAO4FPaG062952@svn.freebsd.org>
 <50B07EB6.3010503@freebsd.org> <50B0D5B3.9000802@FreeBSD.org>
In-Reply-To: <50B0D5B3.9000802@FreeBSD.org>
OpenPGP: id=964474DD
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQnnAfOvCWAbbwYu0sbO+C2yMGNdGgiF5EDkbogaK1CwnWM9dR8jQ/UOWS/pK3YOaCncELuT
Cc: Andrew Turner <andrew@FreeBSD.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Nov 2012 14:51:50 -0000

On 24.11.2012 18:12, Dimitry Andric wrote:
>>> -is_delim(int ch)
>>> +is_delim(wchar_t ch)
>>>   {
>>>       if (wflag) {
>>>           if (ch == ' ' || ch == '\t')
>>>
>>
>> I can't look at the whole code at this moment, but taking standalone
>> this is incorrect comparison for wchar_t. Should be L' ' and L'\t'
>> instead.
> 
> The compiler just promotes the space and tab to wchar_t, this is only
> needed for the sake of consistency (and/or style).  There is no binary
> change if you add the L prefixes. :)

In general case byte order of type promotion is not necessary equal to
byte order of L'x' literals.