From nobody Sat Oct 12 00:46:17 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XQPty1g3Mz5YS11; Sat, 12 Oct 2024 00:46:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XQPtx61KQz4lWC; Sat, 12 Oct 2024 00:46:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728693977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m8cpHaepQYapEJmnhGezo8VaVEZ30SioQy+iujRDaIA=; b=uH8V+p8Wh8AaE7YkJBVoN8HpZfp8h4O/RkJxwqjpDT290NxukRILCRsFRV5E0nSMbYiLCc PIjQngFFpVDztvXI8UxvwfJuiJL4KyA5FjOWybRn6zIEjDwlPpwFpcl7KTTq99bMgKi+KX FPJtwFq5UVn25nfp+daKJlO1+3w9Qtf10bI+wceDej4AyJQjwxRa25uImyL+pu5iVywMTW Cpt68R676TO6YMi2bqhcbbDnXJ0rdcTo2BbrlgOCTc0gd7fi1iuqUArHZclDHx1+uv6vHe l+aYtzkTAx80hDymKq19/M3dRGO9/PL4cVbcgTQG0z6Qj3Fa4QgK6LFuI5Jj4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728693977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m8cpHaepQYapEJmnhGezo8VaVEZ30SioQy+iujRDaIA=; b=XmgK4OKlSJe9cicb3iJixmHBwMmQ0kaF2WvpETz7tmq+LCSI2Cls/PEJdXtI7Htpb0/it9 M9Fby+0hHAzM5BsXEy7+EjeREdqbEt8yg+UZu2iTaBXIv+X1WKYyzYoC3e+KOiWx67C/74 bFxkAPjDy43AL27vTaIjBky3oezr9/wpHmaRGd0zgNpTOevzzPS9LqALU+w7Cd1/9awAhO lrCQGpzvDwsecMQlf5lJg8tgT+B1sJwtE6tMECR+wboa33NBFu4LJ5wM4KGlxllhTAQ/KW jbCwskIJdPfe6PBGNXE3kp2cmsrrnbR1H58VPSGKxqLrjae0BSWkk2oYlXmrZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728693977; a=rsa-sha256; cv=none; b=jKJQ0cG+ICO0+S55ygJV0JEu/0RIZ7VWIuU2KnkZvpf5t+U9Q5/GFq/839BA7mhQU8H+YN FAUCBSRDParoGjaPaflfk7GHgXpprlxveQFFScMsf57Mg7ZSHGONh+Yd3PgIn4oy6vyq9B MLSSZRK9ZgMnrAdfKXwEpZql6KtfqiUzZDF1NH7xjZvB9HsX1+QzCLTNC2m88F31Yy8jq8 mAObORRXF8ztWpe+x6wggj5T9D/15JG/goxQSRBGOHHYKxTLvrjRZtB8v2eUVfozx+m1OA Nvfw+4oLR1YcgIwQflJ5NhUz0epcSsKWHcn/7ZdSxTVeLiV36bbx72dbBY9pjg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XQPtx270mz14KQ; Sat, 12 Oct 2024 00:46:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49C0kHLT088761; Sat, 12 Oct 2024 00:46:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49C0kH8A088758; Sat, 12 Oct 2024 00:46:17 GMT (envelope-from git) Date: Sat, 12 Oct 2024 00:46:17 GMT Message-Id: <202410120046.49C0kH8A088758@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 83ac4cebe84e - stable/14 - Revert "nfscl: Enable support for the Lookup+Open RPC" List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 83ac4cebe84e651e4130e0e31e0c3ceff7affaa1 Auto-Submitted: auto-generated The branch stable/14 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=83ac4cebe84e651e4130e0e31e0c3ceff7affaa1 commit 83ac4cebe84e651e4130e0e31e0c3ceff7affaa1 Author: Rick Macklem AuthorDate: 2024-09-28 22:01:36 +0000 Commit: Rick Macklem CommitDate: 2024-10-12 00:45:22 +0000 Revert "nfscl: Enable support for the Lookup+Open RPC" This reverts commit 9792c7d3eb41dc1e3709e00a98734c3312d1b4fe. The email thread "panic: nfsv4root ref cnt cpuid=1" on freebsd-fs@freebsd.org descibes crashes that occurred for a NFSv4.1 client mount using "oneopenown" where the same file is re-opened many times by different processes. The crashes appear to have been caused by the use of the Lookup+Open RPC (which only happens for mounts using the "oneopenown" option). There appears to be a race between closure of the open and the open acquired by the Lookup+Open RPC. Since Lookup+Open RPCs are only an optimization and can only be done for "oneopenown" at this time, this patch reverts enabling of them. It may be possible to fix the code so that Lookup+Open works reliably, so the code is left in place (although it will never be executed) for now. Reported by: J David (cherry picked from commit 6df05714da160a8ac3e27ee34ff903bd0e760002) --- sys/fs/nfsclient/nfs_clvnops.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index 13341dfc26e0..bf24a161b94b 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -1309,6 +1309,11 @@ nfs_lookup(struct vop_lookup_args *ap) } openmode = 0; +#if 0 + /* + * The use of LookupOpen breaks some builds. It is disabled + * until that is fixed. + */ /* * If this an NFSv4.1/4.2 mount using the "oneopenown" mount * option, it is possible to do the Open operation in the same @@ -1328,6 +1333,7 @@ nfs_lookup(struct vop_lookup_args *ap) openmode |= NFSV4OPEN_ACCESSWRITE; } NFSUNLOCKMNT(nmp); +#endif newvp = NULLVP; NFSINCRGLOBAL(nfsstatsv1.lookupcache_misses);