From owner-cvs-all@FreeBSD.ORG Thu Jul 21 13:15:36 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CE64106566B; Thu, 21 Jul 2011 13:15:36 +0000 (UTC) (envelope-from shaun@FreeBSD.org) Received: from alpha.inerd.com (alpha.inerd.com [204.109.56.118]) by mx1.freebsd.org (Postfix) with ESMTP id 1FC5C8FC0A; Thu, 21 Jul 2011 13:15:36 +0000 (UTC) Received: from charon.picobyte.net (localhost [127.0.0.1]) by alpha.inerd.com (Postfix) with ESMTP id 0F1F2147CD0; Thu, 21 Jul 2011 12:55:15 +0000 (UTC) Date: Thu, 21 Jul 2011 13:55:15 +0100 From: Shaun Amott To: Hiroki Sato Message-ID: <20110721125514.GA57642@charon.picobyte.net> References: <201107202352.p6KNqCkN034366@repoman.freebsd.org> <20110721.123130.698363444164784046.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline In-Reply-To: <20110721.123130.698363444164784046.hrs@allbsd.org> User-Agent: Mutt/1.5.20 (FreeBSD i386) Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: www/en/cgi Makefile www/share/mk web.site.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 13:15:36 -0000 --J/dobhs11T7y2rNN Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote: > Shaun Amott wrote > in <201107202352.p6KNqCkN034366@repoman.freebsd.org>: >=20 > sh> shaun 2011-07-20 23:52:12 UTC > sh> > sh> FreeBSD doc repository (ports committer) > sh> > sh> Modified files: > sh> en/cgi Makefile > sh> share/mk web.site.mk > sh> Log: > sh> Hook up files (Perl modules) for the new query-pr.cgi script. A bit= of > sh> extra code to handle the fact that the files are in subdirectories = was > sh> required. > sh> > sh> Revision Changes Path > sh> 1.35 +14 -1 www/en/cgi/Makefile > sh> 1.77 +9 -1 www/share/mk/web.site.mk > sh> >=20 > Thank you for updating the CGI script, but I do not think it is a > good idea to add CGI_SUB{DIRS,FILES} into web.site.mk. > Sub-directories are handled by bsd.subdir.mk, so it should be used in > straightforward way instead of adding new variables/targets. >=20 > What do you think about the attached patch? I did not notice these > changes were submitted somewhere for review before the commit... >=20 > -- Hiroki Hi Hiroki, The change was a temporary quick-fix to get the PR viewer working again. I am not intimately familiar with the doc build system, so wasn't sure about the best way to add the new subdirectories; but your way looks a lot cleaner to me. The script itself was made available some time ago on freebsd-www, so I considered it reviewed; I just didn't foresee the need for the other changes. Shaun --=20 Shaun Amott // PGP: 0x6B387A9A "A foolish consistency is the hobgoblin of little minds." - Ralph Waldo Emerson --J/dobhs11T7y2rNN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAk4oIbIACgkQkmhdCGs4eppF3ACgj6PlkO5+G4sSeQpQrSZprgNh cF8AoOa6NBYvlxYYHxSFET32hB9TuxGR =3zWx -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN--